From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH RFC batadv] batman-adv: tvlv: enforce 2-byte alignment
Date: Sun, 14 Jun 2026 10:57:07 +0200 [thread overview]
Message-ID: <12932148.O9o76ZdvQC@sven-desktop> (raw)
In-Reply-To: <20260614-tvlv-2b-align-v1-1-6e21383cd287@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Sunday, 14 June 2026 10:19:54 CEST Sven Eckelmann wrote:
> The fields of an aggregated OGM(v2) are accessed assuming (at least) 2-byte
> alignment, so a following OGM must start at an even offset. As the header
> length is even, an odd tvlv_len would misalign it and trigger unaligned
> accesses on strict-alignment architectures.
>
> Such a misaligned TVLV/OGM/OGMv2 is not created by a normal participant in
> the mesh. Therefore, reject such malformed packets.
>
> Fixes: 0b6aa0d43767 ("batman-adv: tvlv - basic infrastructure")
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
batadv_recv_mcast_packet will be added in v2.
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2026-06-14 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-14 8:19 [PATCH RFC batadv] batman-adv: tvlv: enforce 2-byte alignment Sven Eckelmann
2026-06-14 8:57 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12932148.O9o76ZdvQC@sven-desktop \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox