From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 0/6] batman-adv: Add routeable multicast optimizations
Date: Sun, 05 May 2019 19:37:48 +0200 [thread overview]
Message-ID: <12977711.pgt7cpdoR5@sven-edge> (raw)
In-Reply-To: <20190424011919.9821-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 4158 bytes --]
On Wednesday, 24 April 2019 03:19:13 CEST Linus Lüssing wrote:
> The following patchset fills the next gaps in the multicast address
> rules page by adding support for group-aware optimizations for
> multicast addresses of scope greater than link-local. So far, only
> link-local addresses were optimized as packets with routeable
> addresses not only need to be forwarded to local multicast listeners
> but also multicast routers.
[...]
I get a lot of build errors when trying to build these patches. Here is the
complete list, including warnings of other build tests:
Output of different failed tests
================================
ecsv/pu: checkpatch ./net/batman-adv/multicast.c
------------------------------------------------
CHECK: Blank lines aren't necessary before a close brace '}'
#791: FILE: ./net/batman-adv/multicast.c:791:
+
+}
WARNING: Block comments should align the * on each line
#799: FILE: ./net/batman-adv/multicast.c:799:
+ * capabilities and inabilities.
+ */
total: 0 errors, 1 warnings, 1 checks, 2368 lines checked
ecsv/pu: headers
----------------
diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c
index ca4898d3..f106728b 100644
--- a/net/batman-adv/multicast.c
+++ b/net/batman-adv/multicast.c
@@ -23,7 +23,6 @@
#include <linux/inetdevice.h>
#include <linux/ip.h>
#include <linux/ipv6.h>
-#include <linux/jiffies.h>
#include <linux/kernel.h>
#include <linux/kref.h>
#include <linux/list.h>
ecsv/pu: kerneldoc ./net/batman-adv/multicast.c
-----------------------------------------------
./net/batman-adv/multicast.c:803: warning: Function parameter or member 'flags' not described in 'batadv_mcast_mla_flags_update'
ecsv/pu: kerneldoc ./net/batman-adv/types.h
-------------------------------------------
./net/batman-adv/types.h:1200: warning: Function parameter or member 'tvlv_flags' not described in 'batadv_mcast_mla_flags'
ecsv/pu: kerneldoc include/uapi/linux/batadv_packet.h
-----------------------------------------------------
include/uapi/linux/batadv_packet.h:124: warning: Enum value 'BATADV_MCAST_WANT_ALL_RTR6' not described in enum 'batadv_mcast_flags'
include/uapi/linux/batadv_packet.h:124: warning: Excess enum value 'BATADV_MCAST_NO_WANT_ALL_RTR6' description in 'batadv_mcast_flags'
ecsv/pu: sparse linux-3.18 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=y TRACING=n NC=n MCAST=y BATMAN_V=n SYSFS=n
---------------------------------------------------------------------------
In file included from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/main.h:216:0,
from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.c:7:
/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/types.h:1255:13: error: duplicate member ‘mla_lock’
spinlock_t mla_lock;
^~~~~~~~
make[3]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.o] Error 1
make[2]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv] Error 2
make[1]: *** [_module_/home/build_test/build_env/tmp.2gwYBLVNdO] Error 2
make: *** [all] Error 2
ecsv/pu: sparse linux-4.14.104 cfg: BLA=y DAT=y DEBUGFS=y DEBUG=n TRACING=y NC=n MCAST=y BATMAN_V=y SYSFS=y
---------------------------------------------------------------------------
In file included from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/main.h:216:0,
from /home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.c:7:
/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/types.h:1255:13: error: duplicate member ‘mla_lock’
spinlock_t mla_lock;
^~~~~~~~
make[3]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv/bat_algo.o] Error 1
make[2]: *** [/home/build_test/build_env/tmp.2gwYBLVNdO/net/batman-adv] Error 2
make[1]: *** [_module_/home/build_test/build_env/tmp.2gwYBLVNdO] Error 2
make: *** [all] Error 2
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-05-05 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 1:19 [B.A.T.M.A.N.] [PATCH 0/6] batman-adv: Add routeable multicast optimizations Linus Lüssing
2019-04-24 1:19 ` [B.A.T.M.A.N.] [PATCH maint 1/6] batman-adv: mcast: fix multicast tt/tvlv worker locking Linus Lüssing
2019-04-24 1:19 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: mcast: shorten multicast tt/tvlv worker spinlock section Linus Lüssing
2019-04-24 1:19 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: mcast: collect softif listeners from IP lists instead Linus Lüssing
2019-04-24 1:19 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: mcast: avoid redundant multicast TT entries with bridges Linus Lüssing
2019-04-24 1:19 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: mcast: detect, distribute and maintain multicast router presence Linus Lüssing
2019-04-24 1:19 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: mcast: apply optimizations for routeable packets, too Linus Lüssing
2019-05-05 17:37 ` Sven Eckelmann [this message]
2019-05-07 4:22 ` [B.A.T.M.A.N.] [PATCH 0/6] batman-adv: Add routeable multicast optimizations Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12977711.pgt7cpdoR5@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox