public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: "Linus Lüssing" <linus.luessing@web.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] Various fixes and clean-ups
Date: Sun, 13 Mar 2011 20:52:20 +0100	[thread overview]
Message-ID: <1300045945-28734-1-git-send-email-linus.luessing@web.de> (raw)

Hi everyone,

For one thing, I've changed the orig_node->router dereference as discussed on IRC,
now using an extra getter method for that to reduce the lines of code for
rcu-dereferencing, rcu-locking and refcounting for the router pointer
and to make it easier to keep track of the right refcounting (Patch 4/5). Note,
that the previous version was pretty simple, by just using rcu_dereference() everywhere.
However, this current version is a little more invasive, so would be great if
someone could double check that I didn't introduce any new mem-leaks or
null-pointer-dereferences due to wrong refcounting. It already took me quite
some time to find and squash two bugs I had introduced with this, so
there might be even more in there. I double checked it myself and
also tested it in a 4 node chain toplogy vm setup, though.

For Patch 5/5, I've removed the "TQ value" from the patch subject. For the TQ
window locking is definitely needed, whether tq_avg needs locking as well still
needs to be checked. If so, that could be done with a separate patch though.

Patches 1,2,3 are just some smaller changes. Let me know what you think about them.

Cheers, Linus

             reply	other threads:[~2011-03-13 19:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-13 19:52 Linus Lüssing [this message]
2011-03-13 19:52 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Move bonding / iface alternating router search to own functions Linus Lüssing
2011-03-13 19:52 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Make gateway_get_selected type safe Linus Lüssing
2011-03-13 19:52 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Simplify gw_check_election(), use gw_get_selected() Linus Lüssing
2011-03-13 19:52 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Make orig_node->router an rcu protected pointer Linus Lüssing
2011-03-13 19:52 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Protect global TQ window with a spinlock Linus Lüssing
2011-03-14 22:48 ` [B.A.T.M.A.N.] Various fixes and clean-ups Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300045945-28734-1-git-send-email-linus.luessing@web.de \
    --to=linus.luessing@web.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox