From: Sven Eckelmann <sven@narfation.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: accept delayed rebroadcasts to avoid bogus routing under heavy load
Date: Thu, 9 Jun 2011 23:09:09 +0200 [thread overview]
Message-ID: <1307653754-5014-2-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <1307653754-5014-1-git-send-email-sven@narfation.org>
From: Daniele Furlan <daniele.furlan@gmail.com>
When a link is saturated (re)broadcasts of OGMs are delayed. Under heavy
load this delay may exceed the orig interval which leads to OGMs being
dropped (the code would only accept an OGM rebroadcast if it arrived
before the next OGM was broadcasted). With this patch batman-adv will
also accept delayed OGMs in order to avoid a bogus influence on the
routing metric.
Signed-off-by: Daniele Furlan <daniele.furlan@gmail.com>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/routing.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
index 368ceeb..934f1f2 100644
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -698,17 +698,16 @@ void receive_bat_packet(const struct ethhdr *ethhdr,
/* neighbor has to indicate direct link and it has to
* come via the corresponding interface */
- /* if received seqno equals last send seqno save new
- * seqno for bidirectional check */
+ /* save packet seqno for bidirectional check */
if (has_directlink_flag &&
compare_eth(if_incoming->net_dev->dev_addr,
- batman_packet->orig) &&
- (batman_packet->seqno - if_incoming_seqno + 2 == 0)) {
+ batman_packet->orig)) {
offset = if_incoming->if_num * NUM_WORDS;
spin_lock_bh(&orig_neigh_node->ogm_cnt_lock);
word = &(orig_neigh_node->bcast_own[offset]);
- bit_mark(word, 0);
+ bit_mark(word,
+ if_incoming_seqno - batman_packet->seqno - 2);
orig_neigh_node->bcast_own_sum[if_incoming->if_num] =
bit_packet_count(word);
spin_unlock_bh(&orig_neigh_node->ogm_cnt_lock);
--
1.7.5.3
next prev parent reply other threads:[~2011-06-09 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 21:09 [B.A.T.M.A.N.] pull request: batman-adv 2011-06-09 Sven Eckelmann
2011-06-09 21:09 ` Sven Eckelmann [this message]
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: Don't return value in void function Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: Fix signedness problem in parse_gw_bandwidth Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: Rewrite debugfs kobj_to_* helpers as functions Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: Use enums for related constants Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: use NO_FLAGS define instead of hard-coding 0 Sven Eckelmann
2011-06-09 21:58 ` [B.A.T.M.A.N.] pull request: batman-adv 2011-06-09 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307653754-5014-2-git-send-email-sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox