From: Sven Eckelmann <sven@narfation.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: Rewrite debugfs kobj_to_* helpers as functions
Date: Thu, 9 Jun 2011 23:09:12 +0200 [thread overview]
Message-ID: <1307653754-5014-5-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <1307653754-5014-1-git-send-email-sven@narfation.org>
CodingStyle "Chapter 12: Macros, Enums and RTL" highly recommends to use
functions instead of macros were possible. This ensures type safety and
prevents shadowing of other variables.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
net/batman-adv/bat_sysfs.c | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/net/batman-adv/bat_sysfs.c b/net/batman-adv/bat_sysfs.c
index 6f70560..924d577 100644
--- a/net/batman-adv/bat_sysfs.c
+++ b/net/batman-adv/bat_sysfs.c
@@ -28,9 +28,17 @@
#include "gateway_client.h"
#include "vis.h"
-#define to_dev(obj) container_of(obj, struct device, kobj)
-#define kobj_to_netdev(obj) to_net_dev(to_dev(obj->parent))
-#define kobj_to_batpriv(obj) netdev_priv(kobj_to_netdev(obj))
+static struct net_device *kobj_to_netdev(struct kobject *obj)
+{
+ struct device *dev = container_of(obj->parent, struct device, kobj);
+ return to_net_dev(dev);
+}
+
+static struct bat_priv *kobj_to_batpriv(struct kobject *obj)
+{
+ struct net_device *net_dev = kobj_to_netdev(obj);
+ return netdev_priv(net_dev);
+}
/* Use this, if you have customized show and store functions */
#define BAT_ATTR(_name, _mode, _show, _store) \
--
1.7.5.3
next prev parent reply other threads:[~2011-06-09 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-09 21:09 [B.A.T.M.A.N.] pull request: batman-adv 2011-06-09 Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: accept delayed rebroadcasts to avoid bogus routing under heavy load Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: Don't return value in void function Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: Fix signedness problem in parse_gw_bandwidth Sven Eckelmann
2011-06-09 21:09 ` Sven Eckelmann [this message]
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: Use enums for related constants Sven Eckelmann
2011-06-09 21:09 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: use NO_FLAGS define instead of hard-coding 0 Sven Eckelmann
2011-06-09 21:58 ` [B.A.T.M.A.N.] pull request: batman-adv 2011-06-09 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307653754-5014-5-git-send-email-sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox