Re: [PATCH batadv] batman-adv: dat: initialize purge work before hash allocation

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

On Sunday, 4 October 2026 10:21:58 CEST Sven Eckelmann wrote:
> batadv_dat_init() only initializes bat_priv->dat.work after the hash table
> was allocated successfully. batadv_dat_free() unconditionally calls
> disable_delayed_work_sync() on it.
> 
> This is currently not a problem: if batadv_mesh_init() fails,
> batadv_dat_free() is never called. But as this might change in the future,
> initialize the delayed work before anything in batadv_dat_init() can fail
> to make sure that batadv_dat_free() always operates on an initialized work
> item.

I think I will reject this patch because it is a little bit too defensive. 
Instead, I will simply reply to Sashiko that this isn't reachable. Similar to 
the batadv_v_ogm_free()'s mutex_lock() which isn't reachable when the alloc in 
batadv_v_ogm_init fails.

Regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]