public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: [B.A.T.M.A.N.] [PATCH 2/7] batman-adv: Move deinitialization of soft-interface to destructor
Date: Sat, 24 Nov 2012 01:02:07 +0100	[thread overview]
Message-ID: <1353715332-4284-2-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <1353715332-4284-1-git-send-email-sven@narfation.org>

The deinitialization of the soft-interface created in ndo_init/constructor
should be done in the destructor and not directly before calling
unregister_netdevice

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 net/batman-adv/soft-interface.c |   15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/net/batman-adv/soft-interface.c b/net/batman-adv/soft-interface.c
index b545595..8467b9f 100644
--- a/net/batman-adv/soft-interface.c
+++ b/net/batman-adv/soft-interface.c
@@ -487,6 +487,17 @@ static const struct net_device_ops batadv_netdev_ops = {
 	.ndo_validate_addr = eth_validate_addr
 };
 
+/**
+ * batadv_interface_free - Deconstructor of batadv_soft_interface
+ * @dev: Device to cleanup and remove
+ */
+static void batadv_interface_free(struct net_device *dev)
+{
+	batadv_debugfs_del_meshif(dev);
+	batadv_mesh_free(dev);
+	free_netdev(dev);
+}
+
 static void batadv_interface_setup(struct net_device *dev)
 {
 	struct batadv_priv *priv = netdev_priv(dev);
@@ -494,7 +505,7 @@ static void batadv_interface_setup(struct net_device *dev)
 	ether_setup(dev);
 
 	dev->netdev_ops = &batadv_netdev_ops;
-	dev->destructor = free_netdev;
+	dev->destructor = batadv_interface_free;
 	dev->tx_queue_len = 0;
 
 	/* can't call min_mtu, because the needed variables
@@ -535,9 +546,7 @@ struct net_device *batadv_softif_create(const char *name)
 
 void batadv_softif_destroy(struct net_device *soft_iface)
 {
-	batadv_debugfs_del_meshif(soft_iface);
 	batadv_sysfs_del_meshif(soft_iface);
-	batadv_mesh_free(soft_iface);
 	unregister_netdevice(soft_iface);
 }
 
-- 
1.7.10.4


  reply	other threads:[~2012-11-24  0:02 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-24  0:02 [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: Move soft-interface initialization to ndo_init Sven Eckelmann
2012-11-24  0:02 ` Sven Eckelmann [this message]
2012-11-24  0:02 ` [B.A.T.M.A.N.] [PATCH 3/7] batman-adv: Don't always delete softif when last slave was removed Sven Eckelmann
2012-11-24  0:02 ` [B.A.T.M.A.N.] [PATCH 4/7] batman-adv: Remove slave interfaces before removing master interface Sven Eckelmann
2012-11-24  0:02 ` [B.A.T.M.A.N.] [PATCH 5/7] batman-adv: Allow to postpone softif unregistration Sven Eckelmann
2012-11-24  0:02 ` [B.A.T.M.A.N.] [PATCH 6/7] batman-adv: Allow to use rntl_link for device creation/deletion Sven Eckelmann
2012-12-01 13:11   ` Antonio Quartulli
2012-12-01 13:16     ` Sven Eckelmann
2012-12-01 13:28       ` Antonio Quartulli
2012-12-01 13:39         ` Sven Eckelmann
2012-12-01 14:54           ` Antonio Quartulli
2012-11-24  0:02 ` [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: Allow to modify slaves of soft-interfaces through rntl_link Sven Eckelmann
2012-11-24 20:59 ` [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: Move soft-interface initialization to ndo_init David Miller
2012-11-24 21:23   ` Sven Eckelmann
2012-12-24 14:22 ` Pau Koning
2012-12-24 14:37   ` Marek Lindner
2012-12-24 15:36     ` Pau Koning
2012-12-24 19:37       ` Marek Lindner
2012-12-24 23:18         ` Pau Koning
2012-12-25  8:19           ` Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353715332-4284-2-git-send-email-sven@narfation.org \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox