Re: [B.A.T.M.A.N.] [PATCH 7/9] batman-adv-devel: Add missing TARGET_* flags to batctl compile

Marek Lindner
2013-05-12T07:52:13Z

On Wednesday, May 08, 2013 15:24:50 Sven Eckelmann wrote:
> On Wednesday 08 May 2013 13:11:57 Marek Lindner wrote:
> > On Tuesday, May 07, 2013 20:51:07 Sven Eckelmann wrote:
> > > The compilation step of batctl completely dropped the TARGET_CFLAGS,
> > > TARGET_CPPFLAGS and TARGET_LDFLAGS and therefore weren't compiled and
> > > linked with the flags given by the OpenWRT build environment.
> >
> > It seems you missed the meaning of MAKE_BATCTL_ARGS ? This variable
> > contains TARGET_CFLAGS already. We apparently are missing
> > TARGET_CPPFLAGS and TARGET_LDFLAGS. Do you want to resend and make the
> > necessary changes to MAKE_BATCTL_ARGS ?
>
> I didn't felt like fixing your other problems too, but sent two other
> patches resolving the MAKE_BATCTL_ARGS problem. See
> [Bonus-PATCH 10/9] batman-adv-devel: Don't overwrite batctl's CFLAGS
> [Bonus-PATCH 11/9] batman-adv-devel: Remove unused parameters from
> MAKE_BATCTL_ARGS

Applied with minor modifications in revision f41a85c.

Thanks for the explanations as to why that is helpful.

Thanks,
Marek