public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: [B.A.T.M.A.N.] [Bonus-PATCH 10/9] batman-adv-devel: Don't overwrite batctl's CFLAGS
Date: Wed,  8 May 2013 09:21:25 +0200	[thread overview]
Message-ID: <1367997686-12331-1-git-send-email-sven@narfation.org> (raw)

The batctl makefile has CFLAGS which change the behavior of the compiler. This
includes important things like the C-dialect used or whether the compiler can
ignore aliasing problems during the optimization step.

The OpenWRT build environment should not overwrite these settings without a
good reason. Most of these reasons can probably directly be fixed upstream.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 batman-adv-devel/Makefile | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/batman-adv-devel/Makefile b/batman-adv-devel/Makefile
index cad95c6..fb2c24a 100644
--- a/batman-adv-devel/Makefile
+++ b/batman-adv-devel/Makefile
@@ -65,9 +65,6 @@ MAKE_BATMAN_ADV_ARGS += \
 	REVISION="$(PKG_BATMAN_SHORTREV)" all
 
 MAKE_BATCTL_ARGS += \
-	CFLAGS="$(TARGET_CFLAGS)" \
-	CCFLAGS="$(TARGET_CFLAGS)" \
-	OFLAGS="$(TARGET_CFLAGS)" \
 	REVISION="$(PKG_BATCTL_SHORTREV)" \
 	CC="$(TARGET_CC)" \
 	NODEBUG=1 \
-- 
1.8.2.1


             reply	other threads:[~2013-05-08  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  7:21 Sven Eckelmann [this message]
2013-05-08  7:21 ` [B.A.T.M.A.N.] [Bonus-PATCH 11/9] batman-adv-devel: Remove unused parameters from MAKE_BATCTL_ARGS Sven Eckelmann
2013-05-12  7:56   ` Marek Lindner
2013-05-12  7:53 ` [B.A.T.M.A.N.] [Bonus-PATCH 10/9] batman-adv-devel: Don't overwrite batctl's CFLAGS Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1367997686-12331-1-git-send-email-sven@narfation.org \
    --to=sven@narfation.org \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox