From: "Linus Lüssing" <linus.luessing@web.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH] batman-adv: (style) fix for switched vid-ifiindex parameter order
Date: Fri, 14 Jun 2013 11:54:02 +0200 [thread overview]
Message-ID: <1371203642-2224-1-git-send-email-linus.luessing@web.de> (raw)
batadv_tt_local_add() first takes the vid and then the interface index
parameter. One of these calls had the order switched.
However in this case it is not a functional, but just a style fix
because at the moment BATADV_NO_FLAGS is equal to BATADV_NULL_IFINDEX.
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
---
main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/main.c b/main.c
index f2f1137..a7ad6cb 100644
--- a/main.c
+++ b/main.c
@@ -128,7 +128,7 @@ int batadv_mesh_init(struct net_device *soft_iface)
goto err;
batadv_tt_local_add(soft_iface, soft_iface->dev_addr,
- BATADV_NULL_IFINDEX, BATADV_NO_FLAGS);
+ BATADV_NO_FLAGS, BATADV_NULL_IFINDEX);
ret = batadv_bla_init(bat_priv);
if (ret < 0)
--
1.7.10.4
next reply other threads:[~2013-06-14 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-14 9:54 Linus Lüssing [this message]
2013-06-14 12:49 ` [B.A.T.M.A.N.] [PATCH] batman-adv: (style) fix for switched vid-ifiindex parameter order Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1371203642-2224-1-git-send-email-linus.luessing@web.de \
--to=linus.luessing@web.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox