Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Use bool as return type for boolean functions

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1545 bytes --]

On Monday, February 22, 2016 21:02:39 Sven Eckelmann wrote:
> It is easier to understand that the returned value of a specific function
> doesn't have to be 0 when the functions was successful when the actual
> return type is bool. This is especially true when all surrounding functions
> with return type int use negative values to return the error code.
> 
> Reported-by: Nicholas Krause <xerofoify@gmail.com>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
>  net/batman-adv/bat_iv_ogm.c            |  23 ++---
>  net/batman-adv/bitarray.c              |  16 +--
>  net/batman-adv/bitarray.h              |  14 +--
>  net/batman-adv/bridge_loop_avoidance.c | 175
> +++++++++++++++++---------------- net/batman-adv/bridge_loop_avoidance.h
> |  43 ++++----
>  net/batman-adv/debugfs.c               |   2 +-
>  net/batman-adv/distributed-arp-table.c |   6 +-
>  net/batman-adv/hard-interface.c        |  15 ++-
>  net/batman-adv/hash.h                  |   6 +-
>  net/batman-adv/main.h                  |   2 +-
>  net/batman-adv/network-coding.c        |  12 +--
>  net/batman-adv/originator.c            |   4 +-
>  net/batman-adv/originator.h            |   2 +-
>  net/batman-adv/routing.c               |  37 +++----
>  net/batman-adv/routing.h               |   6 +-
>  net/batman-adv/soft-interface.c        |   6 +-
>  net/batman-adv/soft-interface.h        |   2 +-
>  net/batman-adv/translation-table.c     |  31 +++---
>  18 files changed, 203 insertions(+), 199 deletions(-)

Applied in revision d58a135.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]