Re: [B.A.T.M.A.N.] [PATCHv3 3/9] batman-adv: add bat_orig_print function API

Antonio Quartulli
2013-08-16T06:30:40Z

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On Fri, Aug 16, 2013 at 12:05:49PM +0800, Marek Lindner wrote:
> On Tuesday, August 13, 2013 14:43:46 Antonio Quartulli wrote:
> > @@ -991,6 +991,7 @@ struct batadv_forw_packet {
> > * @bat_primary_iface_set: called when primary interface is selected /
> > changed * @bat_ogm_schedule: prepare a new outgoing OGM for the send queue
> > * @bat_ogm_emit: send scheduled OGM
> > + * @bat_orig_print: print the originator table
> > */
> > struct batadv_algo_ops {
> > struct hlist_node list;
> > @@ -1001,6 +1002,8 @@ struct batadv_algo_ops {
> > void (*bat_primary_iface_set)(struct batadv_hard_iface
> > *hard_iface); void (*bat_ogm_schedule)(struct batadv_hard_iface
> > *hard_iface); void (*bat_ogm_emit)(struct batadv_forw_packet
> > *forw_packet); + /* orig_node handling API */
> > + void (*bat_orig_print)(struct batadv_priv *priv, struct seq_file
> > *seq); };
>
> How about adding the info somewhere that this callback is optional ?

Ok, will do it in the kernel doc.

>
> Cheers,
> Marek

--
Antonio Quartulli

..each of us alone is worth nothing..
Ernesto "Che" Guevara

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]