Re: [B.A.T.M.A.N.] [PATCHv3 5/9] batman-adv: add bat_metric_is_equiv_or_better API function

Marek Lindner
2013-08-26T01:49:42Z

On Tuesday, August 13, 2013 14:43:48 Antonio Quartulli wrote:
> +static bool batadv_iv_ogm_metric_is_eob(uint32_t metric, uint32_t
> new_metric) +{
> + return (metric - new_metric < BATADV_TQ_SIMILARITY_THRESHOLD);
> +}
> +

Kernel doc ?

> diff --git a/types.h b/types.h
> index 2b5b1c1..7a12eef 100644
> --- a/types.h
> +++ b/types.h
> @@ -991,6 +991,8 @@ struct batadv_forw_packet {
> * @bat_primary_iface_set: called when primary interface is selected /
> changed * @bat_ogm_schedule: prepare a new outgoing OGM for the send queue
> * @bat_ogm_emit: send scheduled OGM
> + * @bat_metric_is_equiv_or_better: check if new_metric is good enough to
> be + * comparable with metric
> * @bat_orig_print: print the originator table
> */

How about this description:
Returns true if new_metric is equally good or better than metric.

Actually, you could call the parameters metricA and metricB or something along
these lines.

Cheers,
Marek