Re: [B.A.T.M.A.N.] [PATCH v2 02/26] batman-adv: Separate logging header

Markus Pargmann
2014-12-28T11:08:54Z

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

Hi Marek,

On Sun, Dec 28, 2014 at 10:33:58AM +0800, Marek Lindner wrote:
> On Friday 26 December 2014 12:41:19 Markus Pargmann wrote:
> > This patch creates a separate header file for logging related functions
> > and definitions.
>
> Martin's comment still stands. Your commit message states the obvious without
> giving any clue as to why this is desired or wanted ..

Didn't see Martin's comment as my email somewhere was lost in the to
list.

However I am doing this because I think it is better to remove as much
code from main.c/h as possible that is not used for init/shutdown.
Logging functions are not interesting for the reader of main.c, so I
think it should be moved to a separate file.

I will add some similar explanation to the commit message.

Best regards,

Markus

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]