From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: [B.A.T.M.A.N.] [PATCH maint 1/2] Revert "batman-adv: free nf_bridge member on locally delivered skb"
Date: Mon, 23 Dec 2013 01:28:04 +0100 [thread overview]
Message-ID: <1387758485-3568-1-git-send-email-antonio@meshcoding.com> (raw)
This reverts commit 9048eb62124f47f66d12eb1d706ab5fb265553f7.
This fix can be implemented using the nf_Reset() helper
instead of partly reimplementing it with a batman-adv
private function.
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
soft-interface.c | 8 --------
soft-interface.h | 16 ----------------
2 files changed, 24 deletions(-)
diff --git a/soft-interface.c b/soft-interface.c
index 5dd1247..33b6144 100644
--- a/soft-interface.c
+++ b/soft-interface.c
@@ -371,14 +371,6 @@ void batadv_interface_rx(struct net_device *soft_iface,
if (batadv_is_ap_isolated(bat_priv, ethhdr->h_source, ethhdr->h_dest))
goto dropped;
- /* Clean the netfilter state before delivering the skb.
- * This packet may have traversed a bridge when it was encapsulated into
- * the batman header. Now that the header has been removed, the
- * netfilter state must be cleaned up to avoid to mess up with a
- * possible second bridge
- */
- batadv_nf_bridge_skb_free(skb);
-
netif_rx(skb);
goto out;
diff --git a/soft-interface.h b/soft-interface.h
index 5c19c42..2f2472c 100644
--- a/soft-interface.h
+++ b/soft-interface.h
@@ -29,20 +29,4 @@ void batadv_softif_destroy_sysfs(struct net_device *soft_iface);
int batadv_softif_is_valid(const struct net_device *net_dev);
extern struct rtnl_link_ops batadv_link_ops;
-#ifdef CONFIG_BRIDGE_NETFILTER
-/**
- * batadv_nf_bridge_skb_free - clean the NF bridge data in an skb
- * @skb: the skb which nf data has to be free'd
- */
-static inline void batadv_nf_bridge_skb_free(struct sk_buff *skb)
-{
- nf_bridge_put(skb->nf_bridge);
- skb->nf_bridge = NULL;
-}
-#else
-static inline void batadv_nf_bridge_skb_free(struct sk_buff *skb)
-{
-}
-#endif /* CONFIG_BRIDGE_NETFILTER */
-
#endif /* _NET_BATMAN_ADV_SOFT_INTERFACE_H_ */
--
1.8.5.2
next reply other threads:[~2013-12-23 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 0:28 Antonio Quartulli [this message]
2013-12-23 0:28 ` [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: clean nf state when removing protocol header Antonio Quartulli
2013-12-23 12:19 ` Marek Lindner
2013-12-23 12:17 ` [B.A.T.M.A.N.] [PATCH maint 1/2] Revert "batman-adv: free nf_bridge member on locally delivered skb" Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387758485-3568-1-git-send-email-antonio@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox