Re: [B.A.T.M.A.N.] [PATCH 14/14] batman-adv: drop dependency against CRC16

Antonio Quartulli
2014-01-15T13:16:12Z

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On 13/01/14 23:31, Antonio Quartulli wrote:
> The crc16 functionality is not used anymore, therefore
> we can safely remove the dependency in the Kbuild file.
>
> Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>

David,

we just realized that this dependency is still needed by our module.
(also thanks to Fengguang Wu build bot!)

Could you please revert this patch only?
Or do you want me to send the "revert" on the netdev ml as a patch (or
pull request)?

Thanks a lot!

> ---
> net/batman-adv/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/batman-adv/Kconfig b/net/batman-adv/Kconfig
> index fa780b7..2b2dc47 100644
> --- a/net/batman-adv/Kconfig
> +++ b/net/batman-adv/Kconfig
> @@ -5,7 +5,6 @@
> config BATMAN_ADV
> tristate "B.A.T.M.A.N. Advanced Meshing Protocol"
> depends on NET
> - select CRC16
> select LIBCRC32C
> default n
> help
>

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]