Re: [B.A.T.M.A.N.] [RFC 06/23] batman-adv: ELP - adding sysfs parameter for elp interval

Antonio Quartulli
2014-02-11T17:08:56Z

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

On 11/02/14 17:59, Andrew Lunn wrote:
> On Tue, Feb 11, 2014 at 01:48:06PM +0100, Antonio Quartulli wrote:
>> From: Linus Luessing <linus.luessing@web.de>
>>
>> This parameter can be set individually on each interface and
>> allows the configuration of the ndp interval for the link
>
> s/ndp/elp

thanks!

>
>> quality measurements during runtime. Usually it is desirable
>> to set it to a higher (= slower) value on interfaces which
>> have a more static characteristic (e.g. wired interfaces)
>> or very dense neighbourhoods to reduce overhead.
>>
>> Developed by Linus during a 6 months trainee study period in
>> Ascom (Switzerland) AG.
>>
>> Signed-off-by: Linus Luessing <linus.luessing@web.de>
>> Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
>> [antonio@open-mesh.com: respin on top of the latest master]
>> Signed-off-by: Antonio Quartulli <antonio@open-mesh.com>
>> ---
>> sysfs-class-net-batman-adv | 8 +++++++-
>> sysfs.c | 7 +++++++
>> 2 files changed, 14 insertions(+), 1 deletion(-)
>>
>> diff --git a/sysfs-class-net-batman-adv b/sysfs-class-net-batman-adv
>> index 7f34a95..2884c98 100644
>> --- a/sysfs-class-net-batman-adv
>> +++ b/sysfs-class-net-batman-adv
>> @@ -1,4 +1,11 @@
>>
>> +What: /sys/class/net/<mesh_iface>/batman-adv/elp_interval
>> +Date: Mar 2012
>
> Might make sense to update this to 2014?

I kept it as it was when the patch got merged in our repo.
But I think it should match the month it gets introduced in the kernel.

Thanks²!

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]