public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: [B.A.T.M.A.N.] [PATCHv3] batman-adv: use the proper location in ether_addr_copy()
Date: Wed, 26 Feb 2014 14:10:42 +0100	[thread overview]
Message-ID: <1393420242-1698-1-git-send-email-antonio@meshcoding.com> (raw)

Introduced by: 513b2d107a4d88f62b9394926e377d2c6250775f
("batman-adv: prefer ether_addr_copy to memcpy")

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---

Changes from v2:
- added another fix in routing.c

Changes from v1:
- added Reported-by clause

 icmp_socket.c | 2 +-
 routing.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/icmp_socket.c b/icmp_socket.c
index bf07dfd..161ef8f 100644
--- a/icmp_socket.c
+++ b/icmp_socket.c
@@ -230,7 +230,7 @@ static ssize_t batadv_socket_write(struct file *file, const char __user *buff,
 		icmp_packet_rr = (struct batadv_icmp_packet_rr *)icmp_header;
 		if (packet_len == sizeof(*icmp_packet_rr)) {
 			addr = neigh_node->if_incoming->net_dev->dev_addr;
-			ether_addr_copy(icmp_packet_rr->rr, addr);
+			ether_addr_copy(icmp_packet_rr->rr[0], addr);
 		}
 
 		break;
diff --git a/routing.c b/routing.c
index 3855132..3514153 100644
--- a/routing.c
+++ b/routing.c
@@ -340,7 +340,7 @@ int batadv_recv_icmp_packet(struct sk_buff *skb,
 		if (icmp_packet_rr->rr_cur >= BATADV_RR_LEN)
 			goto out;
 
-		ether_addr_copy(&(icmp_packet_rr->rr[icmp_packet_rr->rr_cur]),
+		ether_addr_copy(icmp_packet_rr->rr[icmp_packet_rr->rr_cur],
 				ethhdr->h_dest);
 		icmp_packet_rr->rr_cur++;
 	}
-- 
1.8.4.5


             reply	other threads:[~2014-02-26 13:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-26 13:10 Antonio Quartulli [this message]
2014-03-11  9:53 ` [B.A.T.M.A.N.] [PATCHv3] batman-adv: use the proper location in ether_addr_copy() Marek Lindner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1393420242-1698-1-git-send-email-antonio@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox