public inbox for b.a.t.m.a.n@lists.open-mesh.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@meshcoding.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <antonio@meshcoding.com>
Subject: [B.A.T.M.A.N.] [PATCH next 03/11] batman-adv: fix multicast kerneldoc
Date: Mon, 17 Mar 2014 14:22:46 +0100	[thread overview]
Message-ID: <1395062574-28291-3-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1395062574-28291-1-git-send-email-antonio@meshcoding.com>

The kerneldoc should always use the third person singular in
the long function description.
Moreover it should always try use up to 80 chars per line.

Introduced by 86cb16e5ec1e2d75821006e8f4abbec66fb741ac
("batman-adv: Add IPv4 link-local/IPv6-ll-all-nodes multicast support")

Cc: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
 multicast.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/multicast.c b/multicast.c
index af3fe49..0e8bea8 100644
--- a/multicast.c
+++ b/multicast.c
@@ -256,11 +256,11 @@ out:
  * @skb: the IPv4 packet to check
  * @is_unsnoopable: stores whether the destination is snoopable
  *
- * Check whether the given IPv4 packet has the potential to
- * be forwarded with a mode more optimal than classic flooding.
+ * Checks whether the given IPv4 packet has the potential to be forwarded with a
+ * mode more optimal than classic flooding.
  *
- * If so then return 0. Otherwise -EINVAL is returned or -ENOMEM if we are
- * out of memory.
+ * If so then returns 0. Otherwise -EINVAL is returned or -ENOMEM if we are out
+ * of memory.
  */
 static int batadv_mcast_forw_mode_check_ipv4(struct batadv_priv *bat_priv,
 					     struct sk_buff *skb,
@@ -485,8 +485,8 @@ batadv_mcast_forw_ip_node_get(struct batadv_priv *bat_priv,
  * batadv_mcast_want_forw_unsnoop_node_get - get a node with an unsnoopable flag
  * @bat_priv: the bat priv with all the soft interface information
  *
- * Return an orig_node which has the BATADV_MCAST_WANT_ALL_UNSNOOPABLES flag set
- * and increase its refcount.
+ * Returns an orig_node which has the BATADV_MCAST_WANT_ALL_UNSNOOPABLES flag
+ * set and increases its refcount.
  */
 static struct batadv_orig_node *
 batadv_mcast_forw_unsnoop_node_get(struct batadv_priv *bat_priv)
-- 
1.8.3.2


  parent reply	other threads:[~2014-03-17 13:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 13:22 [B.A.T.M.A.N.] [PATCH next 01/11] batman-adv: remove useless goto Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 02/11] batman-adv: don't mess up with the netdev refcounting if not needed Antonio Quartulli
2014-03-17 13:22 ` Antonio Quartulli [this message]
2014-03-17 16:13   ` [B.A.T.M.A.N.] [PATCH next 03/11] batman-adv: fix multicast kerneldoc Martin Hundebøll
2014-03-17 16:32     ` Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 04/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 05/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 06/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 07/11] " Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 08/11] batman-adv: adjust copyright disclaimer in multicast files Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 09/11] batman-adv: fix code style Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 10/11] batman-adv: fix more " Antonio Quartulli
2014-03-17 16:19   ` Martin Hundebøll
2014-03-17 16:33     ` Antonio Quartulli
2014-03-17 13:22 ` [B.A.T.M.A.N.] [PATCH next 11/11] " Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395062574-28291-3-git-send-email-antonio@meshcoding.com \
    --to=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox