Re: [B.A.T.M.A.N.] [RFCv2 1/6] cfg80211: export expected throughput through get_station()

Antonio Quartulli
2014-04-10T16:22:24Z

[-- Attachment #1: Type: text/plain, Size: 871 bytes --]

On 08/04/14 12:03, Johannes Berg wrote:
> On Sun, 2014-03-30 at 22:34 +0200, Antonio Quartulli wrote:
>
>> - STATION_INFO_INACTIVE_TIME = 1<<0,
>
> Since you're touching these all anyway, maybe convert to use BIT().

Will do!

>
>
>> @@ -1013,6 +1015,9 @@ struct sta_bss_parameters {
>> * @local_pm: local mesh STA power save mode
>> * @peer_pm: peer mesh STA power save mode
>> * @nonpeer_pm: non-peer mesh STA power save mode
>> + * @expected_throughput: expected throughput as reported by the RC algorithm
>> + * about the bitrate having the maximum throughput. This field can be filled
>> + * only by drivers using Minstrel
>
> This value needs a documented unit ... :)

Yep. As suggested by Andrew, I will try to be clear about what unit is
returned.

Thanks a lot for your review!!!!

Cheers,

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]