Re: [B.A.T.M.A.N.] [RFCv2 1/6] cfg80211: export expected throughput through get_station()

Antonio Quartulli
2014-03-31T08:46:21Z

[-- Attachment #1: Type: text/plain, Size: 1349 bytes --]

Hi Andrew,

On 31/03/14 10:22, Andrew Lunn wrote:
>> /**
>> @@ -1013,6 +1015,9 @@ struct sta_bss_parameters {
>> * @local_pm: local mesh STA power save mode
>> * @peer_pm: peer mesh STA power save mode
>> * @nonpeer_pm: non-peer mesh STA power save mode
>> + * @expected_throughput: expected throughput as reported by the RC algorithm
>> + * about the bitrate having the maximum throughput. This field can be filled
>> + * only by drivers using Minstrel
>> */
>> struct station_info {
>> u32 filled;
>> @@ -1051,6 +1056,8 @@ struct station_info {
>> enum nl80211_mesh_power_mode peer_pm;
>> enum nl80211_mesh_power_mode nonpeer_pm;
>>
>> + u32 expected_throughput;
>> +
>
> It would be nice to comment on what the units are. I known from our
> BATMAN V discussions, it is something odd.
>

Thanks for raising the point.

Actually this is something we could discuss with Felix: at the moment
this value uses the same unit used by the cur_tp member of the
minstrel_ht_sta structure.

It should be Mbps/100 --> expected_throughput = 1 ==> 0.01Mbps

When exposing this value to the user (i.e. iw output) I'd recommend to
convert it to Mbps, but for internal purposes I don't see a clear
problem in exporting a value in this form.

Thoughts? Suggestions?

Cheers,

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]