From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: sven@narfation.org
Subject: [B.A.T.M.A.N.] [PATCH] list: fix order of arguments for hlist_add_after(_rcu)
Date: Fri, 15 Aug 2014 13:38:47 +0200 [thread overview]
Message-ID: <1408102727-12671-1-git-send-email-sven@narfation.org> (raw)
From: Ken Helias <kenhelias@firemail.de>
All other add functions for lists have the new item as first argument
and the position where it is added as second argument. This was changed
for no good reason in this function and makes using it unnecessary
confusing.
The name was changed to hlist_add_behind() to cause unconverted code to
generate a compile error instead of using the wrong parameter order.
[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Ken Helias <kenhelias@firemail.de>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> [intel driver bits]
Cc: Hugh Dickins <hughd@google.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[sven@narfation.org: fix parameter order, add compat code]
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
The patch to fix the order of arguments was already submitted to davem via
http://article.gmane.org/gmane.linux.network/326598
compat.h | 6 ++++++
fragmentation.c | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/compat.h b/compat.h
index ed5b815..eb837ae 100644
--- a/compat.h
+++ b/compat.h
@@ -446,4 +446,10 @@ static int __batadv_interface_kill_vid(struct net_device *dev, __be16 proto,\
#endif /* < KERNEL_VERSION(3, 16, 0) */
+#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
+
+#define hlist_add_behind(n, prev) hlist_add_after(prev, n)
+
+#endif /* < KERNEL_VERSION(3, 17, 0) */
+
#endif /* _NET_BATMAN_ADV_COMPAT_H_ */
diff --git a/fragmentation.c b/fragmentation.c
index 022d18a..fc1835c 100644
--- a/fragmentation.c
+++ b/fragmentation.c
@@ -188,7 +188,7 @@ static bool batadv_frag_insert_packet(struct batadv_orig_node *orig_node,
/* Reached the end of the list, so insert after 'frag_entry_last'. */
if (likely(frag_entry_last)) {
- hlist_add_after(&frag_entry_last->list, &frag_entry_new->list);
+ hlist_add_behind(&frag_entry_new->list, &frag_entry_last->list);
chain->size += skb->len - hdr_size;
chain->timestamp = jiffies;
ret = true;
--
2.1.0.rc1
next reply other threads:[~2014-08-15 11:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 11:38 Sven Eckelmann [this message]
2014-11-09 4:29 ` [B.A.T.M.A.N.] [PATCH] list: fix order of arguments for hlist_add_after(_rcu) Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2014-06-06 9:42 [B.A.T.M.A.N.] [PATCH] list: Fix " Ken Helias
2014-06-06 15:50 ` Greg KH
2014-06-06 15:56 ` David Laight
2014-06-06 17:22 ` Paul E. McKenney
2014-06-07 6:45 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1408102727-12671-1-git-send-email-sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox