From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Use common Jenkins Hash implementation
Date: Mon, 26 Nov 2012 11:10:58 +0100 [thread overview]
Message-ID: <1421529.CDZ816kfjh@bentobox> (raw)
In-Reply-To: <2094937.nutMCHjP7e@bentobox>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
On Monday 26 November 2012 10:40:07 Sven Eckelmann wrote:
[...]
> > I don't fully get why we can't use this new implementation in TT. What's
> > wrong with the CRC computation?
>
> The in kernel implementation will create a different hash sum -> tt entries
> will end up in a different bucket -> CRC will be different (please correct
> me about the last step... just had this problem in the back of my head).
Just checked the code and you are doing an XOR of the crc16 of all TT entries.
So TT can also use the jhash function. Will change this stuff in the lunch
break
Thanks,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-26 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 18:23 [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Use common Jenkins Hash implementation Sven Eckelmann
2012-11-25 18:23 ` [B.A.T.M.A.N.] [PATCH 2/5] batman-adv: Define the size of hashtables by hash bits Sven Eckelmann
2012-11-25 18:23 ` [B.A.T.M.A.N.] [PATCH 3/5] batman-adv: Remove size information from hash table Sven Eckelmann
2012-11-25 18:23 ` [B.A.T.M.A.N.] [PATCH 4/5] batman-adv: Remove wrapper structure for hash tables Sven Eckelmann
2012-11-25 18:23 ` [B.A.T.M.A.N.] [PATCH 5/5] batman-adv: Allow to use different sized hash locks array Sven Eckelmann
2012-11-26 9:33 ` [B.A.T.M.A.N.] [PATCH 1/5] batman-adv: Use common Jenkins Hash implementation Antonio Quartulli
2012-11-26 9:40 ` Sven Eckelmann
2012-11-26 10:10 ` Sven Eckelmann [this message]
2012-11-26 12:30 ` Antonio Quartulli
2012-11-26 12:39 ` Sven Eckelmann
2012-11-26 12:46 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421529.CDZ816kfjh@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox