Re: [B.A.T.M.A.N.] [PATCHv3 5/8] batman-adv: consider outgoing interface in OGM sending

Marek Lindner
2013-11-21T01:29:21Z

[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]

On Wednesday 13 November 2013 19:14:49 Simon Wunderlich wrote:
> From: Simon Wunderlich <simon@open-mesh.com>
>
> The current OGM sending an aggregation functionality decides on
> which interfaces a packet should be sent when it parses the forward
> packet struct. However, with the network wide multi interface
> optimization the outgoing interface is decided by the OGM processing
> function.
>
> This is reflected by moving the decision in the OGM processing function
> and add the outgoing interface in the forwarding packet struct. This
> practically implies that an OGM may be added multiple times (once per
> outgoing interface), and this also affects aggregation which needs to
> consider the outgoing interface as well.
>
> Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
> ---
> Changes to PATCH:
> * beautify big if/else block in batadv_iv_ogm_schedule() and comments
> * remove TODO (obviously everyone is confused by that anyway. If
> someone wants to optimize the aggregation later, I'm sure he/she can
> do that without having my TODO in the code. :] )
>
> Changes to RFCv2:
> * rework kerneldoc and comments
> ---
> bat_iv_ogm.c | 146
> ++++++++++++++++++++++++++++++++++++++--------------------
> send.c | 19 ++++++--
> types.h | 7 ++-
> 3 files changed, 115 insertions(+), 57 deletions(-)

Applied in revision 29b9256.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]