Re: [B.A.T.M.A.N.] [PATCHv3 7/8] batman-adv: add debugfs structure for information per interface

Marek Lindner
2013-11-21T01:38:41Z

[-- Attachment #1: Type: text/plain, Size: 1113 bytes --]

On Wednesday 13 November 2013 19:14:51 Simon Wunderlich wrote:
> void batadv_debugfs_init(void)
> {
> struct batadv_debuginfo **bat_debug;
> @@ -378,6 +395,11 @@ void batadv_debugfs_init(void)
> if (!batadv_debugfs)
> goto err;
>
> + batadv_hardif_debugfs =
> debugfs_create_dir(BATADV_DEBUGFS_HARDIF_SUBDIR,
> + batadv_debugfs);
> + if (batadv_hardif_debugfs == ERR_PTR(-ENODEV))
> + goto err;
> +
> for (bat_debug = batadv_general_debuginfos; *bat_debug; ++bat_debug)
> { file = debugfs_create_file(((*bat_debug)->attr).name, S_IFREG |
> ((*bat_debug)->attr).mode,

I see no specific reason to create a 'hardif' subdirectory. We developers may
know what the term relates to but it is reasonable to assume our users do not.
How about adding the interface directory (e.g. wlan0) right next to the batX
directory ? For clarity we could also move the interface directory into the
corresponding batX folder. In case multiple batX interfaces it might makes
things more obvious.

Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]