[B.A.T.M.A.N.] [PATCH maint 1/3] batman-adv: Remove unnecessary braces for test_bit() in DAT

[B.A.T.M.A.N.] [PATCH maint 1/3] batman-adv: Remove unnecessary braces for test_bit() in DAT

[Linus Lüssing]

Fixes: de466678 ("batman-adv: Fix broken DAT capability check")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
 net/batman-adv/distributed-arp-table.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/distributed-arp-table.c b/net/batman-adv/distributed-arp-table.c
index 1caf7d2..63243a3 100644
--- a/net/batman-adv/distributed-arp-table.c
+++ b/net/batman-adv/distributed-arp-table.c
@@ -453,7 +453,7 @@ static bool batadv_is_orig_node_eligible(struct batadv_dat_candidate *res,
 	int j;
 
 	/* check if orig node candidate is running DAT */
-	if (!(test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities)))
+	if (!test_bit(BATADV_ORIG_CAPA_HAS_DAT, &candidate->capabilities))
 		goto out;
 
 	/* Check if this node has already been selected... */
-- 
1.7.10.4

[B.A.T.M.A.N.] [PATCH maint 2/3] batman-adv: Remove unnecessary braces for test_bit() in NC

[Linus Lüssing]

Fixes: dfb27e75 ("batman-adv: Fix broken NC capability check")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
 net/batman-adv/network-coding.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 55a0b28..1a1f7e6 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -894,7 +894,7 @@ void batadv_nc_update_nc_node(struct batadv_priv *bat_priv,
 		goto out;
 
 	/* check if orig node is network coding enabled */
-	if (!(test_bit(BATADV_ORIG_CAPA_HAS_NC, &orig_node->capabilities)))
+	if (!test_bit(BATADV_ORIG_CAPA_HAS_NC, &orig_node->capabilities))
 		goto out;
 
 	/* accept ogms from 'good' neighbors and single hop neighbors */
-- 
1.7.10.4

Re: [B.A.T.M.A.N.] [PATCH maint 2/3] batman-adv: Remove unnecessary braces for test_bit() in NC

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

On Friday, August 14, 2015 17:23:49 Linus Lüssing wrote:
> Fixes: dfb27e75 ("batman-adv: Fix broken NC capability check")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  net/batman-adv/network-coding.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision 5abaf07.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[B.A.T.M.A.N.] [PATCH maint 3/3] batman-adv: Remove unnecessary braces for test_bit() in MCAST

[Linus Lüssing]

Help! Help! \o/ I'm trapped in this commit message!!! :(

Fixes: 1798ad3f ("batman-adv: Fix broken MCAST capability check")
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
 net/batman-adv/multicast.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/multicast.c b/net/batman-adv/multicast.c
index 8bdd69f..4541f08 100644
--- a/net/batman-adv/multicast.c
+++ b/net/batman-adv/multicast.c
@@ -740,7 +740,7 @@ static void batadv_mcast_tvlv_ogm_handler_v1(struct batadv_priv *bat_priv,
 	 * is a completely new orig_node no need to decrease the counter.
 	 */
 	if (orig_mcast_enabled &&
-	    !(test_bit(BATADV_ORIG_CAPA_HAS_MCAST, &orig->capabilities))) {
+	    !test_bit(BATADV_ORIG_CAPA_HAS_MCAST, &orig->capabilities)) {
 		if (orig_initialized)
 			atomic_dec(&bat_priv->mcast.num_disabled);
 		set_bit(BATADV_ORIG_CAPA_HAS_MCAST, &orig->capabilities);
@@ -798,7 +798,7 @@ void batadv_mcast_purge_orig(struct batadv_orig_node *orig)
 
 	spin_lock_bh(&orig->mcast_handler_lock);
 
-	if (!(test_bit(BATADV_ORIG_CAPA_HAS_MCAST, &orig->capabilities)) &&
+	if (!test_bit(BATADV_ORIG_CAPA_HAS_MCAST, &orig->capabilities) &&
 	    test_bit(BATADV_ORIG_CAPA_HAS_MCAST, &orig->capa_initialized))
 		atomic_dec(&bat_priv->mcast.num_disabled);
 
-- 
1.7.10.4

Re: [B.A.T.M.A.N.] [PATCH maint 3/3] batman-adv: Remove unnecessary braces for test_bit() in MCAST

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 399 bytes --]

On Friday, August 14, 2015 17:23:50 Linus Lüssing wrote:
> Help! Help! \o/ I'm trapped in this commit message!!!
> 
> Fixes: 1798ad3f ("batman-adv: Fix broken MCAST capability check")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  net/batman-adv/multicast.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied in revision d126204.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [B.A.T.M.A.N.] [PATCH maint 1/3] batman-adv: Remove unnecessary braces for test_bit() in DAT

[Marek Lindner]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

On Friday, August 14, 2015 17:23:48 Linus Lüssing wrote:
> Fixes: de466678 ("batman-adv: Fix broken DAT capability check")
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
>  net/batman-adv/distributed-arp-table.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied in revision af35586.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]