From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: [B.A.T.M.A.N.] [PATCH v7 05/19] batman-adv: Rename batadv_orig_ifinfo *_free_ref function to *_put
Date: Sun, 17 Jan 2016 11:01:13 +0100 [thread overview]
Message-ID: <1453024887-7215-5-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <1453024887-7215-1-git-send-email-sven@narfation.org>
The batman-adv source code is the only place in the kernel which uses the
*_free_ref naming scheme for the *_put functions. Changing it to *_put
makes it more consistent and makes it easier to understand the connection
to the *_get functions.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
v7:
- removed patches which are now applied in the branch master
- split *_get -> *_put rename patches into smaller patches only renaming single
functions
v6:
- removed patches which are now applied in the branch next
- rebased remaining patches on the patch
"batman-adv: Avoid recursive call_rcu for batadv_nc_node" which was
modified by Marek while he applied the patches (this unfortunately made
some of the remaining patches slightly harder to apply)
v5:
- add hack which allows to compile against stable kernel like 3.2.44 which
also added the kref_get_unless_zero function
v4:
- fix function names in commit messages
- fix double whitespace in batadv_tt_orig_list_entry_release kerneldoc
- add extra patch for batadv_claim_free_ref kerneldoc fix
- change the phrase "free it" in all *_free_ref/*_put functions to "release it"
v3:
- update copyright year
v2:
- split patchset into fixes and kref migration to make it easier when the
decision is made where each patch will be applied
net/batman-adv/bat_iv_ogm.c | 4 ++--
net/batman-adv/network-coding.c | 2 +-
net/batman-adv/originator.c | 10 +++++-----
net/batman-adv/originator.h | 2 +-
net/batman-adv/routing.c | 8 ++++----
5 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c
index 7566cf6..ba48fb2 100644
--- a/net/batman-adv/bat_iv_ogm.c
+++ b/net/batman-adv/bat_iv_ogm.c
@@ -1368,7 +1368,7 @@ batadv_iv_ogm_update_seqnos(const struct ethhdr *ethhdr,
out:
spin_unlock_bh(&orig_node->bat_iv.ogm_cnt_lock);
batadv_orig_node_put(orig_node);
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
return ret;
}
@@ -1514,7 +1514,7 @@ batadv_iv_ogm_process_per_outif(const struct sk_buff *skb, int ogm_offset,
ogm_packet, if_incoming,
if_outgoing, dup_status);
}
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
/* only forward for specific interface, not for the default one. */
if (if_outgoing == BATADV_IF_DEFAULT)
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 8b36765..9180ff1 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -772,7 +772,7 @@ static bool batadv_can_nc_with_orig(struct batadv_priv *bat_priv,
last_ttl = orig_ifinfo->last_ttl;
last_real_seqno = orig_ifinfo->last_real_seqno;
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
if (last_real_seqno != ntohl(ogm_packet->seqno))
return false;
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 7965fe5..6056415 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -743,11 +743,11 @@ static void batadv_orig_ifinfo_release(struct kref *ref)
}
/**
- * batadv_orig_ifinfo_free_ref - decrement the refcounter and possibly release
+ * batadv_orig_ifinfo_put - decrement the refcounter and possibly release
* the orig_ifinfo
* @orig_ifinfo: the orig_ifinfo object to release
*/
-void batadv_orig_ifinfo_free_ref(struct batadv_orig_ifinfo *orig_ifinfo)
+void batadv_orig_ifinfo_put(struct batadv_orig_ifinfo *orig_ifinfo)
{
kref_put(&orig_ifinfo->refcount, batadv_orig_ifinfo_release);
}
@@ -799,7 +799,7 @@ static void batadv_orig_node_release(struct kref *ref)
hlist_for_each_entry_safe(orig_ifinfo, node_tmp,
&orig_node->ifinfo_list, list) {
hlist_del_rcu(&orig_ifinfo->list);
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
}
spin_unlock_bh(&orig_node->neigh_list_lock);
@@ -1012,10 +1012,10 @@ batadv_purge_orig_ifinfo(struct batadv_priv *bat_priv,
ifinfo_purged = true;
hlist_del_rcu(&orig_ifinfo->list);
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
if (orig_node->last_bonding_candidate == orig_ifinfo) {
orig_node->last_bonding_candidate = NULL;
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
}
}
diff --git a/net/batman-adv/originator.h b/net/batman-adv/originator.h
index b4fe828..adbe7aa 100644
--- a/net/batman-adv/originator.h
+++ b/net/batman-adv/originator.h
@@ -69,7 +69,7 @@ batadv_orig_ifinfo_get(struct batadv_orig_node *orig_node,
struct batadv_orig_ifinfo *
batadv_orig_ifinfo_new(struct batadv_orig_node *orig_node,
struct batadv_hard_iface *if_outgoing);
-void batadv_orig_ifinfo_free_ref(struct batadv_orig_ifinfo *orig_ifinfo);
+void batadv_orig_ifinfo_put(struct batadv_orig_ifinfo *orig_ifinfo);
int batadv_orig_seq_print_text(struct seq_file *seq, void *offset);
int batadv_orig_hardif_seq_print_text(struct seq_file *seq, void *offset);
diff --git a/net/batman-adv/routing.c b/net/batman-adv/routing.c
index 9107f69..4dd646a 100644
--- a/net/batman-adv/routing.c
+++ b/net/batman-adv/routing.c
@@ -107,7 +107,7 @@ static void _batadv_update_route(struct batadv_priv *bat_priv,
spin_lock_bh(&orig_node->neigh_list_lock);
rcu_assign_pointer(orig_ifinfo->router, neigh_node);
spin_unlock_bh(&orig_node->neigh_list_lock);
- batadv_orig_ifinfo_free_ref(orig_ifinfo);
+ batadv_orig_ifinfo_put(orig_ifinfo);
/* decrease refcount of previous best neighbor */
if (curr_router)
@@ -548,13 +548,13 @@ next:
batadv_neigh_node_put(cand_router);
cand_router = NULL;
}
- batadv_orig_ifinfo_free_ref(cand);
+ batadv_orig_ifinfo_put(cand);
}
rcu_read_unlock();
/* last_bonding_candidate is reset below, remove the old reference. */
if (orig_node->last_bonding_candidate)
- batadv_orig_ifinfo_free_ref(orig_node->last_bonding_candidate);
+ batadv_orig_ifinfo_put(orig_node->last_bonding_candidate);
/* After finding candidates, handle the three cases:
* 1) there is a next candidate, use that
@@ -567,7 +567,7 @@ next:
/* remove references to first candidate, we don't need it. */
if (first_candidate) {
batadv_neigh_node_put(first_candidate_router);
- batadv_orig_ifinfo_free_ref(first_candidate);
+ batadv_orig_ifinfo_put(first_candidate);
}
router = next_candidate_router;
orig_node->last_bonding_candidate = next_candidate;
--
2.7.0.rc3
next prev parent reply other threads:[~2016-01-17 10:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-17 10:01 [B.A.T.M.A.N.] [PATCH v7 01/19] batman-adv: Rename batadv_orig_node *_free_ref function to *_put Sven Eckelmann
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 02/19] batman-adv: Rename batadv_hardif " Sven Eckelmann
2016-01-17 11:54 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 03/19] batman-adv: Rename batadv_neigh_node " Sven Eckelmann
2016-01-17 11:57 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 04/19] batman-adv: Rename batadv_neigh_ifinfo " Sven Eckelmann
2016-01-17 11:58 ` Marek Lindner
2016-01-17 10:01 ` Sven Eckelmann [this message]
2016-01-17 12:00 ` [B.A.T.M.A.N.] [PATCH v7 05/19] batman-adv: Rename batadv_orig_ifinfo " Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 06/19] batman-adv: Rename batadv_hardif_neigh " Sven Eckelmann
2016-01-17 12:01 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 07/19] batman-adv: Rename batadv_backbone_gw " Sven Eckelmann
2016-01-17 12:03 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 08/19] batman-adv: Rename batadv_claim " Sven Eckelmann
2016-01-17 12:08 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 09/19] batman-adv: Rename batadv_dat_entry " Sven Eckelmann
2016-01-17 12:10 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 10/19] batman-adv: Rename batadv_gw_node " Sven Eckelmann
2016-01-17 12:12 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 11/19] batman-adv: Rename batadv_tvlv_handler " Sven Eckelmann
2016-01-18 1:31 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 12/19] batman-adv: Rename batadv_tvlv_container " Sven Eckelmann
2016-01-18 1:32 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 13/19] batman-adv: Rename batadv_softif_vlan " Sven Eckelmann
2016-01-18 4:50 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 14/19] batman-adv: Rename batadv_nc_node " Sven Eckelmann
2016-01-18 5:40 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 15/19] batman-adv: Rename batadv_nc_path " Sven Eckelmann
2016-01-18 5:45 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 16/19] batman-adv: Rename batadv_orig_node_vlan " Sven Eckelmann
2016-01-18 5:46 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 17/19] batman-adv: Rename batadv_tt_local_entry " Sven Eckelmann
2016-01-18 5:48 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 18/19] batman-adv: Rename batadv_tt_global_entry " Sven Eckelmann
2016-01-18 5:49 ` Marek Lindner
2016-01-17 10:01 ` [B.A.T.M.A.N.] [PATCH v7 19/19] batman-adv: Rename batadv_tt_orig_list_entry " Sven Eckelmann
2016-01-18 5:51 ` Marek Lindner
2016-01-17 11:52 ` [B.A.T.M.A.N.] [PATCH v7 01/19] batman-adv: Rename batadv_orig_node " Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453024887-7215-5-git-send-email-sven@narfation.org \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox