From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@open-mesh.com>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batctl: Fix warning about comparing signed vs. unsigned
Date: Tue, 15 Oct 2013 22:01:51 +0800 [thread overview]
Message-ID: <1453392.LrPeSdtQbS@diderot> (raw)
In-Reply-To: <1381832947-25980-1-git-send-email-sven@open-mesh.com>
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
On Tuesday 15 October 2013 12:29:07 Sven Eckelmann wrote:
> The macros NLMSG_OK and NLMSG_NEXT operate on the parameter len as if it
> would be a variable from the type size_t. Using ssize_t (signed size_t) can
> cause warnings about comparing a signed with an unsigned variable.
>
> It is ok to store the signed len variable in an unsigned variable because an
> check is used to stop processing when it was negative.
>
> Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
> ---
> functions.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Applied in revision c1ffa59.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
prev parent reply other threads:[~2013-10-15 14:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 10:29 [B.A.T.M.A.N.] [PATCH] batctl: Fix warning about comparing signed vs. unsigned Sven Eckelmann
2013-10-15 14:01 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453392.LrPeSdtQbS@diderot \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@open-mesh.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox