Re: [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function

Sven Eckelmann
2016-05-05T20:17:18Z

[-- Attachment #1.1: Type: text/plain, Size: 10298 bytes --]

=2D-nextPart14925138.mhnyUsvyfy
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Friday 06 May 2016 02:46:37 Antonio Quartulli wrote:
> the compiler can optimize functions within the same C file and therefore
> there is no need to make it explicit.
>
> Remove the useless inline attribute for __batadv_store_uint_attr()
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
> net/batman-adv/sysfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

This is not about this particular patch but for the patch series.

Please check the attached test results of the daily build tests.

Kind regards,
Sve
=2D-nextPart14925138.mhnyUsvyfy
Content-Disposition: attachment; filename="gw_per_algo_test.mbox"
Content-Transfer-Encoding: 7Bit
Content-Type: application/mbox; name="gw_per_algo_test.mbox"

Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Build check errors found: 2016-05-05
From: postmaster@open-mesh.org
Date: Thu, 5 May 2016 21:59:37 +0200 (CEST)

Name of failed tests
====================

* headers master
* kerneldoc master ./net/batman-adv/types.h
* unused_symbols master linux-3.10 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.10 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.10 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.10 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.11 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.11 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.11 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.11 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.12 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.12 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.12 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.12 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.13 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.13 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.13 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.13 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.14 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.14 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.14 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.14 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.15 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.15 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.15 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.15 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.16 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.16 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.16 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.16 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.17 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.17 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.17 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.17 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.18 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.18 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.18 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.18 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.19 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.19 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.19 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.19 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.2 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.2 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.2 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.2 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.3 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.3 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.3 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.3 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.4 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.4 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.4 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.4 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.5 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.5 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.5 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.5 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.6 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.6 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.6 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.6 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.7 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.7 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.7 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.7 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.8 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.8 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.8 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.8 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.9 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-3.9 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-3.9 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-3.9 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.0 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-4.0 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-4.0 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.0 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.1 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-4.1 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-4.1 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.1 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.2 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-4.2 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-4.2 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.2 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.3 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-4.3 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-4.3 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.3 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.4 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-4.4 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-4.4 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.4 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.5 cfg: BLA=n DAT=y DEBUG=n NC=n MCAST=y BATMAN_V=n
* unused_symbols master linux-4.5 cfg: BLA=n DAT=y DEBUG=n NC=y MCAST=y BATMAN_V=n
* unused_symbols master linux-4.5 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
* unused_symbols master linux-4.5 cfg: BLA=y DAT=y DEBUG=n NC=n MCAST=n BATMAN_V=n

Output of different failed tests
================================

headers master
=2D-------------

diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
index 02359d0..cb09ae5 100644
--- a/net/batman-adv/bat_v.c
+++ b/net/batman-adv/bat_v.c
@@ -19,6 +19,10 @@
#include "main.h" // IWYU pragma: keep

#include <linux/atomic.h>
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#include <linux/kref.h>
+#include <linux/stddef.h>
#include <linux/bug.h>
#include <linux/cache.h>
#include <linux/init.h>

kerneldoc master ./net/batman-adv/types.h
=2D----------------------------------------

./net/batman-adv/types.h:1338: warning: No description found for parameter 'gw'

unused_symbols master linux-4.5 cfg: BLA=n DAT=y DEBUG=y NC=n MCAST=n BATMAN_V=n
=2D--------------------------------------------------------------------------

batadv_gw_node_get

=2D-nextPart14925138.mhnyUsvyfy--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 550 bytes --]

On Friday 06 May 2016 02:46:37 Antonio Quartulli wrote:
> the compiler can optimize functions within the same C file and therefore
> there is no need to make it explicit.
>
> Remove the useless inline attribute for __batadv_store_uint_attr()
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
> net/batman-adv/sysfs.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

This is not about this particular patch but for the patch series.

Please check the attached test results of the daily build tests.

Kind regards,
Sve

[-- Attachment #1.3: gw_per_algo_test.mbox --]
[-- Type: application/mbox, Size: 9359 bytes --]

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]