Re: [B.A.T.M.A.N.] [PATCH 1/7] batman-adv: remove useless inline attribute for sysfs helper function

Sven Eckelmann
2016-05-15T09:01:49Z

[-- Attachment #1.1: Type: text/plain, Size: 3450 bytes --]

=2D-nextPart3946135.CqBrSdG93e
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

On Sunday 08 May 2016 18:59:56 Sven Eckelmann wrote:
[....]
> Now you can for example run the build tests and receive the mail:
>
> REMOTE=/home/sven/tmp/qemu-batman/batman-adv TO=sven ./checkstuff.sh

The repo was updated to support the multicast patches. I've also introduced
other helper code which automatically sets the TO to the current user and
makes it easier to select the branches/Linux versions to test. For example a
"fast" (like in "only enough time to make a cup of tea") test would be:

REMOTE=/home/sven/tmp/qemu-batman/batman-adv \
TESTBRANCHES="ecsv/misc_patches" INCOMING_BRANCH="ecsv/misc_patches" \
LINUX_VERSIONS="linux-3.2 linux-4.5" \
./checkstuff.sh

> Or you can extract the relevant part of the script (see attachment - file
> paths have to be adjusted; build_test.git with prepared headers is still
> required) and run it manually. Please make sure that you've committed your
> changed before running it because it will remove your local changes.
>
> sh ~/tmp/testheaders.sh

Some adjustments were necessary for the support of the new multicast compat
stuff. I have updated the minimal-test shellscript (see attachments).

Kind regards,
Sven
=2D-nextPart3946135.CqBrSdG93e
Content-Disposition: attachment; filename="testheaders.sh"
Content-Transfer-Encoding: 7Bit
Content-Type: application/x-shellscript; name="testheaders.sh"

#! /bin/sh

LINUX_HEADERS=/home/sven/projekte/build_test/linux-build
LINUX_DEFAULT_VERSION=linux-4.5
IWYU_KERNEL_MAPPINGS=/home/sven/projekte/build_test/testhelpers/kernel_mappings.iwyu
FIX_INCLUDE_SORT=/home/sven/projekte/build_test/testhelpers/fix_includes_sort.py

spath="./net/batman-adv/"
bpath="./net/batman-adv/"

MAKE_CONFIG="CONFIG_BATMAN_ADV_DEBUG=y CONFIG_BATMAN_ADV_BLA=y CONFIG_BATMAN_ADV_DAT=y CONFIG_BATMAN_ADV_MCAST=y CONFIG_BATMAN_ADV_NC=y CONFIG_BATMAN_ADV_BATMAN_V=y KBUILD_SRC=${LINUX_HEADERS}/${LINUX_DEFAULT_VERSION}"

# don't touch main.h, bat_algo.h and files which are required by linux/wait.h, packet.h
sed -i 's/#include "main.h"/#include "main.h" \/\/ IWYU pragma: keep/' "${spath}"/*c "${spath}"/*.h
sed -i 's/\/\* for linux\/wait.h \*\//\/\* for linux\/wait.h \*\/ \/\/ IWYU pragma: keep/' "${spath}"/*c "${spath}"/*.h
sed -i 's/\/\* for packet.h \*\//\/\* for packet.h \*\/ \/\/ IWYU pragma: keep/' "${spath}"/*c "${spath}"/*.h

make KERNELPATH="${LINUX_HEADERS}/${LINUX_DEFAULT_VERSION}" $MAKE_CONFIG || exit

make KERNELPATH="${LINUX_HEADERS}/${LINUX_DEFAULT_VERSION}" $MAKE_CONFIG clean
make KERNELPATH="${LINUX_HEADERS}/${LINUX_DEFAULT_VERSION}" -j1 -k CC="iwyu -Xiwyu --prefix_header_includes=keep -Xiwyu --no_default_mappings -Xiwyu --transitive_includes_only -Xiwyu --verbose=1 -Xiwyu --mapping_file=$IWYU_KERNEL_MAPPINGS" $MAKE_CONFIG 2> test

git add -f "${bpath}" "${spath}"
fix_include --nosafe_headers --separate_project_includes="$(pwd)/${bpath}" < test

# remove extra noise
git checkout -f -- compat-sources
sed -i '/struct batadv_algo_ops;/d' "${bpath}"/main.h
sed -i '/struct batadv_hard_iface;/d' "${bpath}"/main.h
sed -i '/struct batadv_orig_node;/d' "${bpath}"/main.h
sed -i '/struct batadv_priv;/d' "${bpath}"/main.h
"${FIX_INCLUDE_SORT}" --sort_only "${bpath}"/*.c "${bpath}"/*.h

git diff > asd
git checkout -f
less asd

=2D-nextPart3946135.CqBrSdG93e--
This is a multi-part message in MIME format.

[-- Attachment #1.2: Type: text/plain, Size: 1200 bytes --]

On Sunday 08 May 2016 18:59:56 Sven Eckelmann wrote:
[....]
> Now you can for example run the build tests and receive the mail:
>
> REMOTE=/home/sven/tmp/qemu-batman/batman-adv TO=sven ./checkstuff.sh

The repo was updated to support the multicast patches. I've also introduced
other helper code which automatically sets the TO to the current user and
makes it easier to select the branches/Linux versions to test. For example a
"fast" (like in "only enough time to make a cup of tea") test would be:

REMOTE=/home/sven/tmp/qemu-batman/batman-adv \
TESTBRANCHES="ecsv/misc_patches" INCOMING_BRANCH="ecsv/misc_patches" \
LINUX_VERSIONS="linux-3.2 linux-4.5" \
./checkstuff.sh

> Or you can extract the relevant part of the script (see attachment - file
> paths have to be adjusted; build_test.git with prepared headers is still
> required) and run it manually. Please make sure that you've committed your
> changed before running it because it will remove your local changes.
>
> sh ~/tmp/testheaders.sh

Some adjustments were necessary for the support of the new multicast compat
stuff. I have updated the minimal-test shellscript (see attachments).

Kind regards,
Sven

[-- Attachment #1.3: testheaders.sh --]
[-- Type: application/x-shellscript, Size: 1875 bytes --]

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]