From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH (maint?) 1/3] batamn-adv: fix elp packet data reservation
Date: Sun, 21 Aug 2016 08:47:28 +0200 [thread overview]
Message-ID: <1483845.W7oKTuDr2p@sven-edge> (raw)
In-Reply-To: <20160821032534.11074-1-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1318 bytes --]
On Sonntag, 21. August 2016 05:25:32 CEST Linus Lüssing wrote:
[...]
> @@ -334,8 +333,9 @@ int batadv_v_elp_iface_enable(struct batadv_hard_iface *hard_iface)
> goto out;
>
> skb_reserve(hard_iface->bat_v.elp_skb, ETH_HLEN + NET_IP_ALIGN);
> - elp_buff = skb_push(hard_iface->bat_v.elp_skb, BATADV_ELP_HLEN);
> - elp_packet = (struct batadv_elp_packet *)elp_buff;
> + skb_put(hard_iface->bat_v.elp_skb, BATADV_ELP_HLEN);
> + elp_packet = (struct batadv_elp_packet *)
> + hard_iface->bat_v.elp_skb->data;
> memset(elp_packet, 0, BATADV_ELP_HLEN);
>
> elp_packet->packet_type = BATADV_ELP;
>
I don't get right now why you did the of split the skb_put into two different
"ugly" lines (skb_put + the elp_packet assignment without elp_buff). I fear
that this weird (non)-alignment you've created will bite us when the patch is
submitted upstream.
Maybe you can tell us more about why this removal of elp_buff is necessary.
Btw. please use the prefix "batman-adv" in the subject and not "batamn-adv" ;)
And it is at the moment not important whether it goes into next or
maint. Both will be submitted by Simon to net.git because we are currently
completely off with our timing (compared to the upstream submissions).
I personally would go for maint.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-08-21 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-21 3:25 [B.A.T.M.A.N.] [PATCH (maint?) 1/3] batamn-adv: fix elp packet data reservation Linus Lüssing
2016-08-21 3:25 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: elp: skb network header API instead of skb->data access Linus Lüssing
2016-08-21 3:35 ` Linus Lüssing
2016-08-23 1:17 ` Linus Lüssing
2016-08-21 3:25 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: fix batadv_forw_packet kerneldoc for list attribute Linus Lüssing
2016-08-21 3:51 ` Linus Lüssing
2016-08-21 6:22 ` Sven Eckelmann
2016-08-21 6:47 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483845.W7oKTuDr2p@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox