From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH v4 1/6] batman-adv: split routing API data structure in subobjects
Date: Tue, 31 May 2016 20:25:16 +0200 [thread overview]
Message-ID: <1488113.KCrKATXhSP@bentobox> (raw)
In-Reply-To: <20160525152736.9031-2-a@unstable.cc>
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
On Wednesday 25 May 2016 23:27:31 Antonio Quartulli wrote:
> The routing API data structure contains several function
> pointers that can easily be grouped together based on the
> component they work with.
>
> Split the API in subobjects in order to improve definition readability.
>
> At the same time, remove the "bat_" prefix from the API object and
> its fields names. These are batman-adv private structs and there is no
> need to always prepend such prefix, which only makes function invocations
> much much longer.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
My eyes don't want to read diffs anymore which only removes bat_ and replaces
a "_" with a ".". I want more interesting stuff happening in my
movies^Wpatches :)
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Btw. this is rather unrelated to your patch. But the kerneldoc contains
"(optional)" statements. Following functions don't have it (and didn't have it
before your patch):
* iface.activate
* neigh.hardif_init
* orig.free
* orig.add_if
* orig.del_if
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-31 18:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 15:27 [B.A.T.M.A.N.] [PATCH v4 0/6] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support Antonio Quartulli
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 1/6] batman-adv: split routing API data structure in subobjects Antonio Quartulli
2016-05-31 18:25 ` Sven Eckelmann [this message]
2016-06-07 2:13 ` Marek Lindner
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 2/6] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 3/6] batman-adv: statically print gateway table header Antonio Quartulli
2016-05-31 17:50 ` Sven Eckelmann
2016-06-07 6:22 ` Marek Lindner
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 4/6] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 5/6] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-05-27 13:48 ` Sven Eckelmann
2016-05-27 13:57 ` Antonio Quartulli
2016-05-27 14:01 ` Sven Eckelmann
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 6/6] batman-adv: disable sysfs knobs when GW-mode is not implemented Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488113.KCrKATXhSP@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox