From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: restructure rebroadcast counter into forw_packet API
Date: Mon, 06 Feb 2017 11:25:00 +0100 [thread overview]
Message-ID: <1502082.JgMhZiz8zA@bentobox> (raw)
In-Reply-To: <20170129135743.21312-6-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Sonntag, 29. Januar 2017 14:57:42 CET Linus Lüssing wrote:
> This patch refactors the num_packets counter of a forw_packet in the
> following three ways:
>
> 1) Removed dual-use of forw_packet::num_packets:
> -> now for aggregation purposes only
> 2) Using forw_packet::skb::cb::num_bcasts instead:
> -> for easier access in aggregation code later
> 3) make access to num_bcasts private to batadv_forw_packet_*()
I like this change but have some questions (but no time to check it). Is cb
initialized when a new skbuff is allocated? And what about the initialization
for packets we get via batadv_interface_tx? At least batman-adv is only
setting it to zero when we receive a new packet from an hardif
(batadv_batman_skb_recv).
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-02-06 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-29 13:57 [B.A.T.M.A.N.] [PATCH 0/6] batman-adv: broadcast packet aggregation Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: Allow TVLVs greater than 128 bytes Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: aggregation packet reception Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: aggregation packet queueing and transmission Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: privatize forw_packet skb assignment Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: restructure rebroadcast counter into forw_packet API Linus Lüssing
2017-02-06 10:25 ` Sven Eckelmann [this message]
2017-02-09 10:20 ` Linus Lüssing
2017-01-29 13:57 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: do not aggregate rebroadcasts in the same packet Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502082.JgMhZiz8zA@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox