From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sven Eckelmann Subject: Re: [PATCH v2] alfred: notify event listener via unix socket Date: Tue, 17 May 2022 13:32:38 +0200 Message-ID: <150256550.B0Qo63onoq@ripper> In-Reply-To: <10034333.HCmk49s6kI@rousseau> References: <20220502114651.771309-1-mareklindner@neomailbox.ch> <1727325.kRQH6uYu6r@sven-desktop> <10034333.HCmk49s6kI@rousseau> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3002785.Nb0gmuCmfD"; micalg="pgp-sha512"; protocol="application/pgp-signature" Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: To: b.a.t.m.a.n@lists.open-mesh.org, Marek Lindner --nextPart3002785.Nb0gmuCmfD Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Sven Eckelmann To: b.a.t.m.a.n@lists.open-mesh.org, Marek Lindner Subject: Re: [PATCH v2] alfred: notify event listener via unix socket Date: Tue, 17 May 2022 13:32:38 +0200 Message-ID: <150256550.B0Qo63onoq@ripper> In-Reply-To: <10034333.HCmk49s6kI@rousseau> References: <20220502114651.771309-1-mareklindner@neomailbox.ch> <1727325.kRQH6uYu6r@sven-desktop> <10034333.HCmk49s6kI@rousseau> On Tuesday, 17 May 2022 09:44:07 CEST Marek Lindner wrote: [...] > Thanks for preparing the rebase & code change patches. Wouldn't you say that > EPOLL_CTL_DEL somewhere near unix_sock_event_listener_free() could be helpful? > > Something like: > -static void unix_sock_event_listener_free(struct event_listener *listener) > +static void unix_sock_event_listener_free(struct globals *globals, > + struct event_listener *listener) > { > list_del(&listener->list); > + epoll_ctl(globals->epollfd, EPOLL_CTL_DEL, listener->fd, NULL); > close(listener->fd); > free(listener); > } No, alfred doesn't share file descriptors and thus close of the fd will do this for us [1]. Kind regards, Sven [1] https://man7.org/linux/man-pages/man7/epoll.7.html "Will closing a file descriptor cause it to be removed from all epoll interest lists?" --nextPart3002785.Nb0gmuCmfD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAmKDh9YACgkQXYcKB8Em e0bFhw//Uh+OS5sbFzW8niO3tpN+1aXzK5mQ9SvUcf05uvbcSfuYUFQ5KUvM77V6 dNXRlBWJ84MjJU6A0Oxga6wyFR47UysM/nbRO91Xxpob0WXZ437i15MoHH7mvOw6 w6Hha3cLAFhiCRyMSnlYv1R99CArSPB2DCruWGCmE4C+hgM3cqUdXVHOQNTpiAmk 4YyS7FsZFvBZyySZwo7NRZtrTs+aYtv+SIrN3FO6hjcoeO6lA4VEZxAHuj9Lm8nt 7Igcd68/kDE0ZlR/iRn86qyaFKxjmXmV2MK++aMvvHAO7OFshrl72sVzPr/8Js+E a/rEoj22kkg9ZFGQx8qPInK7g3lltZ2iw+BIXfHIdder8E2xwxNCi2CX/+m1H5tp WMxdXerzqEb5dmmB39OYWYnIJueL/2S1x7WJVVaklnA9j2PJLHi10U9TedBlzs1k uZKo6dtm29ewqFj4XcDIukaZvKkYZnu1kl5wtgC+IAIIPhoCT5dlHSb093PZYMNe Z+tk4zPmmMkvOm4XK2p/6lGExcuQC30Xnpngw9VtyvBqV+5ygEqBwRGhKB/uuO/M Jhi8714u7DUdhS46IvRMISrdLMv4BI1CYojEKB9EZJc+8PsRAFd2HjljVRvmgDoM HpHQ2PU8N0pVCERZLCk5RIa6TOAR7c7dLQaDz6rBEX/ooTQYcvY= =IxM9 -----END PGP SIGNATURE----- --nextPart3002785.Nb0gmuCmfD--