From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: bandwidth meter implementation
Date: Thu, 23 Aug 2012 16:21:56 +0200 [thread overview]
Message-ID: <1512568.fRsqxxKJDW@bentobox> (raw)
In-Reply-To: <1345729318-12804-2-git-send-email-montik@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Thursday 23 August 2012 15:41:58 Edo Monticelli wrote:
> /* ICMP message types */
> -enum batadv_icmp_packettype {
> - BATADV_ECHO_REPLY = 0,
> +enum icmp_packettype {
> + BATADV_ECHO_REPLY = 0,
> BATADV_DESTINATION_UNREACHABLE = 3,
I heavily protest against the change of the enum name back to the pre-prefix
name.
There is still a TODO inside the diff and you have variables which are
assigned but not used.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-23 14:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 13:41 [B.A.T.M.A.N.] [RFC] GSOC:bandwidth meter (batadv) Edo Monticelli
2012-08-23 13:41 ` [B.A.T.M.A.N.] [PATCH] batman-adv: bandwidth meter implementation Edo Monticelli
2012-08-23 14:21 ` Sven Eckelmann [this message]
2012-08-31 14:04 ` Simon Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512568.fRsqxxKJDW@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox