From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Sven Eckelmann <sven@narfation.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] alfred: Close socket after connect failure
Date: Thu, 05 Feb 2015 19:09:55 +0100 [thread overview]
Message-ID: <1525155.WDXWpZloLX@prime> (raw)
In-Reply-To: <1423147633-13147-1-git-send-email-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Thursday 05 February 2015 15:47:13 Sven Eckelmann wrote:
> The socket is still using one file descriptor of the process when the
> connection fails. This fd leak is non-problematic in the current client
> process code because the client would be closed in this situation anyway
> and therefore the socket would be closed when the process is stopped. But
> people using this as example code may not stop the process on this error.
> The unclosed and unused sockets would accumulate and the process would hit
> the limit for open file descriptors.
>
> Signed-off-by: Sven Eckelmann <sven@narfation.org>
applied in revision 26a7b5e.
Thanks!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2015-02-05 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 14:47 [B.A.T.M.A.N.] [PATCH] alfred: Close socket after connect failure Sven Eckelmann
2015-02-05 18:09 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525155.WDXWpZloLX@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox