Re: [B.A.T.M.A.N.] [PATCH v2] batman-adv: init ELP tweaking options only once

Marek Lindner
2016-05-11T07:40:35Z

[-- Attachment #1: Type: text/plain, Size: 1418 bytes --]

On Wednesday, May 11, 2016 09:29:22 Sven Eckelmann wrote:
> This needs to check if BATMAN_V is enabled:
>
> /home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv/hard-interface.
> c:689:31: error: no member 'bat_v' in struct batadv_hard_iface
> /home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv/hard-interface.c:6
> 91:31: error: no member 'bat_v' in struct batadv_hard_iface
> /home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv/hard-interface.c:
> In function 'batadv_hardif_add_interface':
> /home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv/hard-interface.c:6
> 89:24: error: 'struct batadv_hard_iface' has no member named 'bat_v'
> atomic_set(&hard_iface->bat_v.throughput_override, 0);
> ^
> /home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv/hard-interface.
> c:691:24: error: 'struct batadv_hard_iface' has no member named 'bat_v'
> atomic_set(&hard_iface->bat_v.elp_interval, 500);
> ^
> make[2]: ***
> [/home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv/hard-interface.o]
> Error 1 make[1]: ***
> [_module_/home/build_test/build_env/tmp.Fco0ibFY6r/net/batman-adv] Error 2
> make: *** [all] Error 2

OMG.

> This report was brought to you by todays build test [1] - the leading
> provider of "omg, batman-adv doesn't build cleanly"

YMMD! I propose that to be the quote of the month! :D

Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]