From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH] RFC: batman-adv: Remove unused primary_if variable
Date: Tue, 24 May 2016 14:59:20 +0200 [thread overview]
Message-ID: <1549543.i0QYfO90aX@prime> (raw)
In-Reply-To: <1876515.iCZETFfYbK@prime>
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
On Tuesday 24 May 2016 14:49:31 Simon Wunderlich wrote:
> Hi,
>
> On Tuesday 24 May 2016 18:00:18 Antonio Quartulli wrote:
> > On Tue, May 24, 2016 at 12:31:17AM +0200, Linus Lüssing wrote:
> > > Fixes: 29b9256e6631 ("batman-adv: consider outgoing interface in OGM
> > > sending") Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> > > ---
> > >
> > > Note sure whether the "forw_packet->if_incoming != primary_if" check
> > > vanished on purpose or by accident in the mentioned commit. Or whether
> > > it
> > > got substituted by some other check. Therefore sending the patch as RFC.
> >
> > I think Simon can better comment on this, but my understanding is that
> > such
> > check has been moved to batadv_iv_ogm_schedule(), thus primary_if is
> > useless in this function.
> >
> > Simon, comments ?
>
> Yes, the check has been moved. I would agree that the check is redundant
> now. Please resend without RFC and add my Acked-by :)
What I meant: the local variable is redundant now. I should start reading what
I type up ... ;) Sorry!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-05-24 12:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 22:31 [B.A.T.M.A.N.] [PATCH] RFC: batman-adv: Remove unused primary_if variable Linus Lüssing
2016-05-24 10:00 ` Antonio Quartulli
2016-05-24 12:49 ` Simon Wunderlich
2016-05-24 12:59 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549543.i0QYfO90aX@prime \
--to=sw@simonwunderlich.de \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox