From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sven@narfation.org>
From: Sven Eckelmann <sven@narfation.org>
Date: Fri, 18 May 2018 23:46:56 +0200
Message-ID: <1566281.z125QuZFdt@sven-edge>
In-Reply-To: <20180515155908.23839-1-linus.luessing@c0d3.blue>
References: <20180515155908.23839-1-linus.luessing@c0d3.blue>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2176817.6yEHGR4ReK";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Subject: Re: [B.A.T.M.A.N.] [PATCH v4] batman-adv: Snoop DHCPACKs for DAT
List-Id: The list for a Better Approach To Mobile Ad-hoc Networking
 <b.a.t.m.a.n.lists.open-mesh.org>
List-Unsubscribe: <https://lists.open-mesh.org/mm/options/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=unsubscribe>
List-Archive: <http://lists.open-mesh.org/pipermail/b.a.t.m.a.n/>
List-Post: <mailto:b.a.t.m.a.n@lists.open-mesh.org>
List-Help: <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=help>
List-Subscribe: <https://lists.open-mesh.org/mm/listinfo/b.a.t.m.a.n>,
 <mailto:b.a.t.m.a.n-request@lists.open-mesh.org?subject=subscribe>
To: b.a.t.m.a.n@lists.open-mesh.org

--nextPart2176817.6yEHGR4ReK
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

On Dienstag, 15. Mai 2018 17:59:08 CEST Linus L=FCssing wrote:
[...]
> diff --git a/include/uapi/linux/batadv_packet.h b/include/uapi/linux/
batadv_packet.h
> index 894d8d2f..6a48f36c 100644
> --- a/include/uapi/linux/batadv_packet.h
> +++ b/include/uapi/linux/batadv_packet.h
> @@ -630,6 +630,46 @@ struct batadv_tvlv_mcast_data {
>  	__u8 reserved[3];
>  };
> =20
> +enum batadv_bootpop {
> +	BATADV_BOOTREPLY	=3D 2,
> +};
> +
> +enum batadv_boothtype {
> +	BATADV_HTYPE_ETHERNET	=3D 1,
> +};
> +
> +enum batadv_dhcpoptioncode {
> +	BATADV_DHCP_OPT_PAD		=3D 0,
> +	BATADV_DHCP_OPT_MSG_TYPE	=3D 53,
> +	BATADV_DHCP_OPT_END		=3D 255,
> +};
> +
> +enum batadv_dhcptype {
> +	BATADV_DHCPACK		=3D 5,
> +};
> +
> +/* { 99, 130, 83, 99 } */
> +#define BATADV_DHCP_MAGIC 1669485411
> +
> +struct batadv_dhcp_packet {
> +	__u8 op;
> +	__u8 htype;
> +	__u8 hlen;
> +	__u8 hops;
> +	__be32 xid;
> +	__be16 secs;
> +	__be16 flags;
> +	__be32 ciaddr;
> +	__be32 yiaddr;
> +	__be32 siaddr;
> +	__be32 giaddr;
> +	__u8 chaddr[16];
> +	__u8 sname[64];
> +	__u8 file[128];
> +	__be32 magic;
> +	__u8 options[0];
> +};
> +
>  #pragma pack()
> =20
>  #endif /* _UAPI_LINUX_BATADV_PACKET_H_ */

Please correct me but it doesn't look like these things have anything to do=
=20
with the batman-adv packet format. And userspace should also not use the=20
bootp_pkt/batadv_dhcp_packet definition from batman-adv.

And what about the basically duplicated bootp_pkt definition in net/ipv4/
ipconfig.c?

Kind regards,
	Sven
--nextPart2176817.6yEHGR4ReK
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEF10rh2Elc9zjMuACXYcKB8Eme0YFAlr/SdAACgkQXYcKB8Em
e0aAYA//T2Klz/tnAO+ieZpyjzYFhzFHjGY7yJsf/UUrbAhwv5sgGVbfRCYA2mVn
JDOIax3C3TE07WakwaFEfkv9q9Y6Qj3GEtbnw4NREWjTQcvXpyDuR4uElRBu1G8a
7qjzmKf7M47tBQyWXdaGFt+XrzFgE/ah+Kehs/VNjmR943Yr4Moz8k+uw9ZoRKla
5Imqcz1LnQpgrVksSPFUtA45OQvXAWVNLkvxppXeJntCkAL+LWjfrsb0A+IxVArc
IwqjBbeJmPJOnGEwv7rAfH6O9C4doGuTOTMif66PoISIByMJfKYQxzUYW01+wrJD
BmPwHrqHOuItAs30PLLvaVxreTggZSJfdizMKJXoiJ/9/X+pMSUTisne+GcDfSlo
Bmy/oSe/feEhxuq6eIfRYntg4XLoAasyOc0FfHTeHHGBZgjrsjQnVS00rW2eAugF
i/oNes4WSdC5V895GSmPHO4jFb/q+cfVVDwGtc0DceEnkzJbLqqAKQZUydtQ/FoN
o6tfFEszgGQ2VDjBr2z0Xkp9mJyDoouJe0xlAOp200qKsBJdJHYm2St+Wy5BaBQv
bVkp6M53P4jnDJZpmco6PJ2TZZ4XUTetY/Qo7FCR+xN/mceweLzzjOK01Sy4n3N1
UCE8bRe0QzUakAikCero1/VuSqLKp2QgYm+wr7q0/OpXbXXqaPI=
=VnVN
-----END PGP SIGNATURE-----

--nextPart2176817.6yEHGR4ReK--