From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv5 3/3] compat: Compat code for IGMP/MLD report unicast forwarding
Date: Thu, 07 May 2015 09:33:17 +0200 [thread overview]
Message-ID: <1572715.c14tfryD1Z@bentobox> (raw)
In-Reply-To: <1430940562-12148-4-git-send-email-linus.luessing@c0d3.blue>
On Wednesday 06 May 2015 21:29:22 Linus Lüssing wrote:
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> Makefile | 4 +
> compat-include/linux/igmp.h | 13 ++
> compat-include/linux/skbuff.h | 14 +++
> compat-include/net/addrconf.h | 13 ++
> compat-include/net/ip6_checksum.h | 18 +++
> compat-include/net/ipv6.h | 17 +++
> compat-include/net/mld.h | 52 ++++++++
> compat-sources/Makefile | 3 +
> compat-sources/net/core/skbuff.c | 136 +++++++++++++++++++++
> compat-sources/net/ipv4/igmp.c | 169 ++++++++++++++++++++++++++
> compat-sources/net/ipv6/mcast_snoop.c | 216
> +++++++++++++++++++++++++++++++++ 11 files changed, 655 insertions(+)
> create mode 100644 compat-include/linux/igmp.h
> create mode 100644 compat-include/net/addrconf.h
> create mode 100644 compat-include/net/ip6_checksum.h
> create mode 100644 compat-include/net/ipv6.h
> create mode 100644 compat-include/net/mld.h
> create mode 100644 compat-sources/Makefile
> create mode 100644 compat-sources/net/core/skbuff.c
> create mode 100644 compat-sources/net/ipv4/igmp.c
> create mode 100644 compat-sources/net/ipv6/mcast_snoop.c
The split header files were only there to fix the problem of the header mess
which couldn't be resolved with a single compat.h that forced a specific
include order. It is not really necessary to have the same for the source
files. Maybe your solution is good or maybe not. Only the future will tell. :)
The other solution would be more like backports [1]. They seem to use one
backport-/compat-*.c file for each kernel they support and introduced features
which they require. So all kernel < 3.19 will build the content of
backport-3.19.c to get the functions introduced by this version. But there are
also some larger ones for special stuff. Maybe you can check this out and
decide what you like more.
To the copyright stuff... hm, if you didn't write it yourself then the
copyright stuff from the original source should be there. backports [1]
doesn't seem to do this very well. They have for example used larger portions
from files marked as copyright Yu Zhao <yu.zhao@intel.com> but have only the
copyright header with Copyright (c) 2013 Luis R. Rodriguez <mcgrof@do-not-
panic.com>. Not sure that I can give a good answer here. Maybe someone else
has an opinion about this part
To the Makefile integration: I did it with compat.c similar before dropping
it. The only difference was that I only had one file
export batman-adv-y += ../../compat.o
So you solution seems to be fine.
Kind regards,
Sven
[1] https://www.kernel.org/pub/linux/kernel/projects/backports/stable/
next prev parent reply other threads:[~2015-05-07 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 19:29 [B.A.T.M.A.N.] [PATCHv5 0/3] batman-adv: Unicasting multicast reports to querier-node only Linus Lüssing
2015-05-06 19:29 ` [B.A.T.M.A.N.] [PATCHv5 1/3] batman-adv: Forward IGMP/MLD reports to selected querier (only) Linus Lüssing
2015-05-06 19:29 ` [B.A.T.M.A.N.] [PATCHv5 2/3] batman-adv: Increase BATADV_TVLV_MCAST version number to 2 Linus Lüssing
2015-05-06 19:29 ` [B.A.T.M.A.N.] [PATCHv5 3/3] compat: Compat code for IGMP/MLD report unicast forwarding Linus Lüssing
2015-05-07 7:33 ` Sven Eckelmann [this message]
2015-05-17 0:40 ` Linus Lüssing
2015-05-06 19:38 ` [B.A.T.M.A.N.] [PATCHv5 0/3] batman-adv: Unicasting multicast reports to querier-node only Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572715.c14tfryD1Z@bentobox \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).