Re: [B.A.T.M.A.N.] [PATCH v4 02/31] batman-adv: Fix list removal of batadv_hardif_neigh_node

Marek Lindner
2016-01-06T16:04:57Z

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

On Tuesday, January 05, 2016 12:06:17 Sven Eckelmann wrote:
> The neigh_list with batadv_hardif_neigh_node objects is accessed with only
> rcu_read_lock in batadv_hardif_neigh_get and batadv_iv_neigh_print. Thus it
> is not allowed to kfree the object before the rcu grace period ends (which
> may still protects context accessing this object). Therefore the object has
> first to be removed from the neigh_list and then it has either wait with
> synchronize_rcu or call_rcu till the grace period ends before it can be
> freed.
>
> Fixes: fed2826b490c ("batman-adv: add list of unique single hop neighbors
> per hard-interface") Signed-off-by: Sven Eckelmann <sven@narfation.org>
> ---
> v4:
> - fix function names in commit messages
> - fix double whitespace in batadv_tt_orig_list_entry_release kerneldoc
> - add extra patch for batadv_claim_free_ref kerneldoc fix
> - change the phrase "free it" in all *_free_ref/*_put functions to "release
> it" v3:
> - update copyright year
> v2:
> - split patchset into fixes and kref migration to make it easier when the
> decision is made where each patch will be applied
>
> net/batman-adv/originator.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)

Applied in revision 6219a1b.

Thanks,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]