Re: [B.A.T.M.A.N.] [PATCH v4 11/31] batman-adv: Drop reference to netdevice on last reference

Antonio Quartulli
2016-01-11T15:58:57Z

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

On 05/01/16 19:06, Sven Eckelmann wrote:
> +void batadv_hardif_release(struct batadv_hard_iface *hard_iface)
> {
> - struct batadv_hard_iface *hard_iface;
> -
> - hard_iface = container_of(rcu, struct batadv_hard_iface, rcu);
> dev_put(hard_iface->net_dev);

Sven,

what is wrong in releasing the releasing the reference to net_dev inside
the RCU callback (except for introducing some delay) ?

Cheers,

--
Antonio Quartulli

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]