Re: [B.A.T.M.A.N.] Antwort: Re: [PATCH 1/7] batman-adv: prevent multiple ARP replies sent by gateways if dat enabled

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 2422 bytes --]

On Thursday 25 February 2016 14:06:39 Andreas Pape wrote:
> I wasn't aware that there is something like the build_test to be used
> before
> sending patches.... But I'm willing to learn.

No, build_test is not something which has be used. It is actually quite hacky
and only used in the daily tests (and by brave people still wanting to use
it).

But you should [1] compile your stuff with sparse. Install it and run the compile
with:

   make C=2 CHECK="sparse -Wsparse-all -Wno-ptr-subtraction-blows -D__CHECK_ENDIAN__"

You can ignore the "shadows an earlier one" in the external headers and the
one about __ret.

And you should definitely use the checkpatch.pl from linux-next:

    ~/linux-next/scripts/checkpatch.pl --strict 000*.patch

> Is there a documentation available how I can use this myself for testing
> before
> making another attempt to send the patches (including a cover letter)?

If you really want to test it with build_test then you have to clone it on
an amd64 system, install iwyu (3.5+), python and the standard build tools.
This example expects that you have a working mail server on your system
which at least can send mails to a local account (YOUR_MAIL_ACCOUNT). The
patches in YOUR_BATMAN_ADV_TREE should be in the master branch to avoid too
many changes checkstuff.sh.

    git clone git://git.open-mesh.org/build_test.git
    cd build_test
    git clone git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git linux-next
    git --git-dir=linux-next/.git/ remote add net-next git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
    LINUX_REPOSITORY=`pwd`/linux-next ./generate_linux_headers.sh
    sudo mkdir linux-build
    sudo mount linux-build.img -o loop linux-build
    # edit checkstuff.sh and remove: testbranch "next"
    TO=YOUR_MAIL_ACCOUNT REMOTE=YOUR_BATMAN_ADV_TREE ./checkstuff.sh
    # fix all the stuff regarding sparse, cppcheck, smatch and try again:
    TO=YOUR_MAIL_ACCOUNT REMOTE=YOUR_BATMAN_ADV_TREE ./checkstuff.sh

Cover letter can be generated in git sendmail by running:

   git send-email --compose 0001-.... 0002-... ....

It is not really required. I just wanted to tell you that the result is not
really about this single patch. But please add all patches to the call of
`git send-email` to automatically create a single thread.

Kind regards,
	Sven

[1] https://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]