From: Simon Wunderlich <sw@simonwunderlich.de>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Fix netlink dumping of BLA claims
Date: Mon, 26 Feb 2018 17:34:20 +0100 [thread overview]
Message-ID: <1590623.xibrY8hj9p@prime> (raw)
In-Reply-To: <20180224110337.11985-1-sven@narfation.org>
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Saturday, February 24, 2018 12:03:36 PM CET Sven Eckelmann wrote:
> The function batadv_bla_claim_dump_bucket must be able to handle
> non-complete dumps of a single bucket. It tries to do that by saving the
> latest dumped index in *idx_skip to inform the caller about the current
> state.
>
> But the caller only assumes that buckets were not completely dumped when
> the return code is non-zero. This function must therefore also return a
> non-zero index when the dumping of an entry failed. Otherwise the caller
> will just skip all remaining buckets.
>
> And the function must also reset *idx_skip back to zero when it finished a
> bucket. Otherwise it will skip the same number of entries in the next
> bucket as the previous one had.
I've applied both patches in this series in 49197c00 and 29e4759e.
Thank you!
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2018-02-26 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 11:03 [B.A.T.M.A.N.] [PATCH maint 1/2] batman-adv: Fix netlink dumping of BLA claims Sven Eckelmann
2018-02-24 11:03 ` [B.A.T.M.A.N.] [PATCH maint 2/2] batman-adv: Fix netlink dumping of BLA backbones Sven Eckelmann
2018-02-26 16:34 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590623.xibrY8hj9p@prime \
--to=sw@simonwunderlich.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox