From: Marek Lindner <mareklindner@neomailbox.ch>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCHv3 maint] batman-adv: protect tt_local_entry from concurrent delete events
Date: Fri, 19 Jun 2015 16:53:48 +0800 [thread overview]
Message-ID: <1600539.cQqiUDHWci@voltaire> (raw)
In-Reply-To: <5583D6B5.7050706@meshcoding.com>
[-- Attachment #1: Type: text/plain, Size: 831 bytes --]
On Friday, June 19, 2015 10:45:41 Antonio Quartulli wrote:
> On 19/06/15 09:18, Marek Lindner wrote:
> > The tt_local_entry deletion performed in batadv_tt_local_remove() was
> > neither protecting against simultaneous deletes nor checking whether the
> > element was still part of the list before calling hlist_del_rcu().
> >
> >
> >
> > Replacing the hlist_del_rcu() call with batadv_hash_remove() provides
> > adequate protection via hash spinlocks as well as an
> > is-element-still-in-hash check to avoid 'blind' hash removal.
> >
> >
> >
> > Fixes: 2443ba3 ("batman-adv: roaming handling mechanism redesign")
> >
> >
> >
> > Reported-by: alfonsname@web.de
> > Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
>
> Acked-by: Antonio Quartulli <antonio@meshcoding.com>
Applied in revision af912d7.
Regards,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2015-06-19 8:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 7:18 [B.A.T.M.A.N.] [PATCHv3 maint] batman-adv: protect tt_local_entry from concurrent delete events Marek Lindner
2015-06-19 8:45 ` Antonio Quartulli
2015-06-19 8:53 ` Marek Lindner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600539.cQqiUDHWci@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox