From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Antonio Quartulli <a@unstable.cc>
Subject: Re: [B.A.T.M.A.N.] [PATCH v4 5/6] batman-adv: B.A.T.M.A.N. V - implement GW selection logic
Date: Fri, 27 May 2016 15:48:37 +0200 [thread overview]
Message-ID: <1623801.mhGnxyytJi@bentobox> (raw)
In-Reply-To: <20160525152736.9031-6-a@unstable.cc>
[-- Attachment #1: Type: text/plain, Size: 1134 bytes --]
On Wednesday 25 May 2016 23:27:35 Antonio Quartulli wrote:
> +#ifdef CONFIG_BATMAN_ADV_BATMAN_V
> +struct batadv_gw_node *batadv_gw_node_get(struct batadv_priv *bat_priv,
> + struct batadv_orig_node *orig_node);
> +#endif /* CONFIG_BATMAN_ADV_BATMAN_V */
This is rather odd because the function is also compiled (and used) even when
CONFIG_BATMAN_ADV_BATMAN_V is not enabled.
Here is the relevant diff:
> @@ -356,9 +360,8 @@ static void batadv_gw_node_add(struct batadv_priv *bat_priv,
> *
> * Return: gateway node if found or NULL otherwise.
> */
> -static struct batadv_gw_node *
> -batadv_gw_node_get(struct batadv_priv *bat_priv,
> - struct batadv_orig_node *orig_node)
> +struct batadv_gw_node *batadv_gw_node_get(struct batadv_priv *bat_priv,
> + struct batadv_orig_node *orig_node)
> {
> struct batadv_gw_node *gw_node_tmp, *gw_node = NULL;
>
Maybe you should drop the CONFIG_BATMAN_ADV_BATMAN_V check.
But I should at least whitelist the batadv_gw_node_get for the unused symbols
check.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-27 13:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 15:27 [B.A.T.M.A.N.] [PATCH v4 0/6] GW code: make it algorithm-agnostic and add B.A.T.M.A.N. V support Antonio Quartulli
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 1/6] batman-adv: split routing API data structure in subobjects Antonio Quartulli
2016-05-31 18:25 ` Sven Eckelmann
2016-06-07 2:13 ` Marek Lindner
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 2/6] batman-adv: make the GW selection class algorithm specific Antonio Quartulli
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 3/6] batman-adv: statically print gateway table header Antonio Quartulli
2016-05-31 17:50 ` Sven Eckelmann
2016-06-07 6:22 ` Marek Lindner
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 4/6] batman-adv: make GW election code protocol specific Antonio Quartulli
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 5/6] batman-adv: B.A.T.M.A.N. V - implement GW selection logic Antonio Quartulli
2016-05-27 13:48 ` Sven Eckelmann [this message]
2016-05-27 13:57 ` Antonio Quartulli
2016-05-27 14:01 ` Sven Eckelmann
2016-05-25 15:27 ` [B.A.T.M.A.N.] [PATCH v4 6/6] batman-adv: disable sysfs knobs when GW-mode is not implemented Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623801.mhGnxyytJi@bentobox \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox