[B.A.T.M.A.N.] patch for manpage batctl.8: Missing description of gw_mode sel_class for B.A.T.M.A.N. V

[B.A.T.M.A.N.] patch for manpage batctl.8: Missing description of gw_mode sel_class for B.A.T.M.A.N. V

[Ruben]

[-- Attachment #1.1: Type: text/plain, Size: 1284 bytes --]

This will resolve https://www.open-mesh.org/issues/366


--- /tmp/smartgit7095787147690981841tmp/compare__827356725346254060_batctl.8
+++
/tmp/smartgit7095787147690981841tmp/compare__6833548133995178090_batctl.8
@@ -144,6 +144,9 @@
 If the node is a gateway client the parameter will decide which
criteria to consider when the batman-adv module has to choose
 between different internet connections announced by the aforementioned
servers.
 .RE
+.RS 9
+B.A.T.M.A.N. IV:
+.RE
 .RS 17
 default: 20 \-> late switch (TQ 20)
 .RE
@@ -166,6 +169,19 @@
 .RS 7
 chooses the gateway with the best link quality but switches to another
gateway as soon as a better one is found which is at
 least XX TQ better than the currently selected gateway (XX has to be a
number between 3 and 256).
+.RE
+.RE
+.RS 9
+B.A.T.M.A.N. V:
+.RE
+.RS 17
+default: 5000 \-> late switch (5000 kbit/s throughput)
+example: 1500 \-> fast switch connection
+.RS 16
+switches to another gateway as soon as a better one is found which is
at least
+1500 kbit/s faster throughput than the currently selected gateway.
Throughput is
+determined by evaluating which is lower: the advertised throughput by the
+gateway or the maximum bandwidth across the entire path.
 .RE
 .RE
 .br


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [B.A.T.M.A.N.] patch for manpage batctl.8: Missing description of gw_mode sel_class for B.A.T.M.A.N. V

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

On Dienstag, 27. November 2018 13:43:33 CET Ruben wrote:
> This will resolve https://www.open-mesh.org/issues/366

Please use `git format-patch -1` to create a patch file (of the last commit). 
And then send it via `git send-email --to=b.a.t.m.a.n@lists.open-mesh.org` to 
the mailing list. The patch you've send here cannot be applied with git-am.

Also don't forget to add the Signed-off-by: ... line. And use a proper Subject 
and commit message [1]. And please no "This will resolve
https://www.open-mesh.org/issues/366" in the actual commit message.

Kind regards,
	Sven.


[1] https://www.open-mesh.org/projects/open-mesh/wiki/Contribute#Submitting-patches

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[B.A.T.M.A.N.] batctl: Add section to explain gateway selection class for BATMAN_V

[Ruben Barkow]

[-- Attachment #1.1.1: Type: text/plain, Size: 181 bytes --]

As mentioned here: https://www.open-mesh.org/issues/366#note-8

I added a fix to the formatting, so this is the final patch:

Signed-off-by: Ruben Barkow <github@r.z11.de>



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: 0001-batctl-Add-section-to-explain-gateway-selection-clas.patch --]
[-- Type: text/x-patch; name="0001-batctl-Add-section-to-explain-gateway-selection-clas.patch", Size: 1673 bytes --]

From c3561b556c57546b2a089b830bd78ada7cd46218 Mon Sep 17 00:00:00 2001
From: rubo77 <github@r.z11.de>
Date: Tue, 27 Nov 2018 13:40:29 +0100
Subject: [PATCH] batctl: Add section to explain gateway selection class for
 BATMAN_V

Signed-off-by: Ruben Barkow <github@r.z11.de>
---
 man/batctl.8 | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/man/batctl.8 b/man/batctl.8
index 2e3232f..ed8e71f 100644
--- a/man/batctl.8
+++ b/man/batctl.8
@@ -144,6 +144,9 @@ examples:  5000 \->  5.0/1.0 MBit
 If the node is a gateway client the parameter will decide which criteria to consider when the batman-adv module has to choose
 between different internet connections announced by the aforementioned servers.
 .RE
+.RS 7
+B.A.T.M.A.N. IV:
+.RE
 .RS 17
 default: 20 \-> late switch (TQ 20)
 .RE
@@ -168,6 +171,20 @@ chooses the gateway with the best link quality but switches to another gateway a
 least XX TQ better than the currently selected gateway (XX has to be a number between 3 and 256).
 .RE
 .RE
+.RS 7
+B.A.T.M.A.N. V:
+.RE
+.RS 17
+default: 5000 \-> late switch (5000 kbit/s throughput)
+.br
+example: 1500 \-> fast switch connection
+.RS 17
+switches to another gateway as soon as a better one is found which is at least 
+1500 kbit/s faster throughput than the currently selected gateway. Throughput is
+determined by evaluating which is lower: the advertised throughput by the
+gateway or the maximum bandwidth across the entire path.
+.RE
+.RE
 .br
 .IP "\fBrouting_algo\fP|\fBra\fP [\fBalgorithm\fP]\fP"
 If no parameter is given the current routing algorithm configuration as well as
-- 
2.17.1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [B.A.T.M.A.N.] batctl: Add section to explain gateway selection class for BATMAN_V

[Antonio Quartulli]

[-- Attachment #1.1: Type: text/plain, Size: 311 bytes --]

Hi,

On 28/11/2018 00:00, Ruben Barkow wrote:
> As mentioned here: https://www.open-mesh.org/issues/366#note-8
> 
> I added a fix to the formatting, so this is the final patch:
> 
> Signed-off-by: Ruben Barkow <github@r.z11.de>

Acked-by: Antonio Quartulli <a@unstable.cc>

-- 
Antonio Quartulli


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [B.A.T.M.A.N.] batctl: Add section to explain gateway selection class for BATMAN_V

[Sven Eckelmann]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Dienstag, 27. November 2018 15:00:39 CET Ruben Barkow wrote:
> As mentioned here: https://www.open-mesh.org/issues/366#note-8

Applied as 26b483ce543e [1]. Thanks for taking care of the wiki entry and the 
manpage.

Please send it next time as inline patch [2]. I had to manually adjust the 
commit message because of that. Otherwise it would have looked like this:

    batctl: Add section to explain gateway selection class for BATMAN_V
    
    As mentioned here: https://www.open-mesh.org/issues/366#note-8
    
    I added a fix to the formatting, so this is the final patch:
    
    Signed-off-by: Ruben Barkow <github@r.z11.de>
    Acked-by: Antonio Quartulli <a@unstable.cc>
    
    >From c3561b556c57546b2a089b830bd78ada7cd46218 Mon Sep 17 00:00:00 2001
    From: rubo77 <github@r.z11.de>
    Date: Tue, 27 Nov 2018 13:40:29 +0100
    Subject: [PATCH] batctl: Add section to explain gateway selection class for
     BATMAN_V
    
    Signed-off-by: Ruben Barkow <github@r.z11.de>
    Signed-off-by: Sven Eckelmann <sven@narfation.org>

Kind regards,
	Sven


[1] https://git.open-mesh.org/batctl.git/commit/26b483ce543e5b4bf6869a66c0ef28ef7a00e367
[2] https://www.kernel.org/doc/html/v4.19/process/email-clients.html

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]