From: Sven Eckelmann <sven@narfation.org>
To: Philipp Psurek <philipp.psurek@gmail.com>
Cc: martin@hundeboll.net, batman-ml <b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [RFC] batman-adv: Calculate extra tail size based on queued fragments
Date: Mon, 01 Dec 2014 19:36:24 +0100 [thread overview]
Message-ID: <1636479.Afs8AsjRjg@sven-edge> (raw)
In-Reply-To: <1417456897.2788.2.camel@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2144 bytes --]
On Monday 01 December 2014 19:01:37 Philipp Psurek wrote:
> I’d like to inform you that I implement the patch posted with this mail
> 18 h ago. It is a mix of the patch Martin gave me earlier and your 1st
> patch from “Calculate extra tail size based on queued fragments”. There
> was no crash, but this means nothing. Now I see, there are many, many
> patches which solves the bug with different approaches. Please tell me
> exactly which one I should test because I don't speak any C.
The mixed patch is a good start and doesn't really have to be changed for your
test of this specific problem. It misses parts but at least the important
change is included. The "final" patches which may need to be tested are (and
these should be merged into batman-adv maint):
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012613.html
(this is already in your patch)
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012620.html
(this is not really your problem but I doubt that this is related to any
problem you see - but just keep it in mind)
Optional and not relevant for your problem (these should be merged _together_
into batman-adv master):
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012614.html
https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2014-December/012615.html
(these are partially included in your patch - unfortunately your patch misses
the part from 012614. And 012615 requires 012614 to work correctly. So just
cross your fingers that no one exploits this).
So if you want to have a clean test setup then please include the two non-
optional patches (012613, 012620). It is also ok to just include 012613
because this one is most likely related to your problem.
The problem in 012620 should only happen when the difference between batman-
adv MTU and device MTU is far too big. A difference of around 1400 bytes. Or
if the device MTU is smaller than 1400 then the batman-adv MTU has to be
around twice as big as the device MTU. This doesn't seem to be the case here
according to your description.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-12-01 18:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 23:05 [B.A.T.M.A.N.] [RFC] batman-adv: Calculate extra tail size based on queued fragments Sven Eckelmann
2014-11-30 23:14 ` [B.A.T.M.A.N.] [RFC-mini] " Sven Eckelmann
2014-12-01 9:23 ` [B.A.T.M.A.N.] [RFC] " Sven Eckelmann
2014-12-01 18:01 ` Philipp Psurek
2014-12-01 18:36 ` Sven Eckelmann [this message]
2014-12-01 20:40 ` Philipp Psurek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636479.Afs8AsjRjg@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=martin@hundeboll.net \
--cc=philipp.psurek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox