From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Patch "batman-adv: Consider fragmentation for needed_headroom" has been added to the 5.4-stable tree From: Date: Tue, 23 Nov 2021 13:33:40 +0100 In-Reply-To: <20211120124053.261156-2-sven@narfation.org> Message-ID: <163767082091109@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: b.a.t.m.a.n@lists.open-mesh.org, gregkh@linuxfoundation.org, linus.luessing@c0d3.blue, sven@narfation.org, sw@simonwunderlich.de Cc: stable-commits@vger.kernel.org This is a note to let you know that I've just added the patch titled batman-adv: Consider fragmentation for needed_headroom to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=3Dlinux/kernel/git/stable/stable-queue.git= ;a=3Dsummary The filename of the patch is: batman-adv-consider-fragmentation-for-needed_headroom.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Tue Nov 23 01:32:30 PM CET 2021 From: Sven Eckelmann Date: Sat, 20 Nov 2021 13:40:51 +0100 Subject: batman-adv: Consider fragmentation for needed_headroom To: stable@vger.kernel.org Cc: b.a.t.m.a.n@lists.open-mesh.org, "Sven Eckelmann" ,= "Linus L=FCssing" , "Simon Wunderlich" Message-ID: <20211120124053.261156-2-sven@narfation.org> From: Sven Eckelmann commit 4ca23e2c2074465bff55ea14221175fecdf63c5f upstream. If a batman-adv packets has to be fragmented, then the original batman-adv packet header is not stripped away. Instead, only a new header is added in front of the packet after it was split. This size must be considered to avoid cost intensive reallocations during the transmission through the various device layers. Fixes: 7bca68c7844b ("batman-adv: Add lower layer needed_(head|tail)room to= own ones") Reported-by: Linus L=C3=BCssing Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich Signed-off-by: Sven Eckelmann Signed-off-by: Greg Kroah-Hartman --- net/batman-adv/hard-interface.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/batman-adv/hard-interface.c +++ b/net/batman-adv/hard-interface.c @@ -554,6 +554,9 @@ static void batadv_hardif_recalc_extra_s needed_headroom =3D lower_headroom + (lower_header_len - ETH_HLEN); needed_headroom +=3D batadv_max_header_len(); =20 + /* fragmentation headers don't strip the unicast/... header */ + needed_headroom +=3D sizeof(struct batadv_frag_packet); + soft_iface->needed_headroom =3D needed_headroom; soft_iface->needed_tailroom =3D lower_tailroom; } Patches currently in stable-queue which might be from sven@narfation.org are queue-5.4/batman-adv-consider-fragmentation-for-needed_headroom.patch queue-5.4/batman-adv-reserve-needed_-room-for-fragments.patch queue-5.4/batman-adv-don-t-always-reallocate-the-fragmentation-skb-head.pat= ch