Re: [PATCH 1/3] batman-adv: bcast: queue per interface, if needed

Sven Eckelmann
2019-05-25T10:21:32Z

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

On Tuesday, 14 May 2019 09:38:57 CEST Linus Lüssing wrote:
> which we only broadcast on once the queueing induces an unncessary

unnecessary

> /**
> * batadv_forw_packet_bcasts_left() - check if a retransmission is necessary
> * @forw_packet: the forwarding packet to check
> @@ -811,28 +1031,20 @@ int batadv_add_bcast_packet_to_list(struct batadv_priv *bat_priv,
> * Return: True if (re)transmissions are left, false otherwise.
> */
> static bool
> -batadv_forw_packet_bcasts_left(struct batadv_forw_packet *forw_packet,
> - struct batadv_hard_iface *hard_iface)
> +batadv_forw_packet_bcasts_left(struct batadv_forw_packet *forw_packet)

/home/sven/tmp/qemu-batman/batman-adv/net/batman-adv/send.c:1191: warning: Excess function parameter 'hard_iface' description in 'batadv_forw_packet_bcasts_left'

Kind regards,
Sven