Re: [PATCH 3/3] batman-adv: forward broadcast packets via unicast transmissions

Sven Eckelmann
2019-05-25T10:21:11Z

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

On Tuesday, 14 May 2019 09:38:59 CEST Linus Lüssing wrote:
> +static bool batadv_forw_bcast_may_ucast(struct batadv_priv *bat_priv,
> + struct batadv_hard_iface *if_out)
> +{
> + unsigned long num_direct_orig;
> + unsigned long num_bcast_no_urcv;
> +
> + num_direct_orig = atomic_read(&if_out->num_direct_orig);
> + num_bcast_no_urcv = atomic_read(&if_out->num_bcast_no_urcv);
> +
> + return !num_bcast_no_urcv &&
> + (num_direct_orig <= atomic_read(&bat_priv->multicast_fanout));
> +}

ecsv/pu|sparse linux-3.16.66 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y SYSFS=y|/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:928:57: error: no member 'multicast_fanout' in struct batadv_priv
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:928:47: warning: call with no type!
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c: In function ‘batadv_forw_bcast_may_ucast’:
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:928:50: error: ‘struct batadv_priv’ has no member named ‘multicast_fanout’
(num_direct_orig <= atomic_read(&bat_priv->multicast_fanout));
^~
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:929:1: warning: control reaches end of non-void function [-Wreturn-type]
}

Kind regards,
Sven