From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support
Date: Mon, 16 May 2016 19:42:09 +0200 [thread overview]
Message-ID: <1646180.Hz16yHrbtt@sven-edge> (raw)
In-Reply-To: <1463414932-1152-1-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 2935 bytes --]
On Monday 16 May 2016 18:08:41 Andrew Lunn wrote:
> * Complete all the kerneldoc cut/paste work requested by Sven.
Hihi, thank you :)
It would have been nice when you would also have added a comment about all the
other changes. I've noticed:
* added missing attribute BATADV_ATTR_THROUGHPUT to the policy (thanks)
* batadv_netlink_get_ifindex was moved from netlink.h to netlink.c
here some more detailed things (not really relevant)
* added originator.h to the wrong place in netlink.c
* some different line breaks in batadv_iv_ogm_neigh_dump_neigh
("genlmsg_put(msg, portid, seq, ....").
* similar changes was done in batadv_algo_dump_entry
* extra linebreak in batadv_netlink_dump_hardifs for
batadv_netlink_get_ifindex
* extra linebreak in batadv_tt_local_dump_entry for genlmsg_put
* extra linebreak in batadv_tt_global_dump_subentry for genlmsg_put
Name of failed tests
====================
* bracket_align ecsv/netlink ./net/batman-adv/bat_iv_ogm.c
* headers ecsv/netlink
Output of different failed tests
================================
bracket_align ecsv/netlink ./net/batman-adv/bat_iv_ogm.c
--------------------------------------------------------
Found wrong alignment at ./net/batman-adv/bat_iv_ogm.c:2375, was 37 but expected 61
Found wrong alignment at ./net/batman-adv/bat_iv_ogm.c:2376, was 37 but expected 61
headers ecsv/netlink
--------------------
diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
index 25fd4be..c5e6db5 100644
--- a/net/batman-adv/bat_v.c
+++ b/net/batman-adv/bat_v.c
@@ -19,9 +19,9 @@
#include "main.h"
#include <linux/bug.h>
+#include <linux/cache.h>
#include <linux/errno.h>
#include <linux/if_ether.h>
-#include <linux/cache.h>
#include <linux/init.h>
#include <linux/jiffies.h>
#include <linux/netdevice.h>
diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
index 949a048..e0fd914 100644
--- a/net/batman-adv/netlink.c
+++ b/net/batman-adv/netlink.c
@@ -36,10 +36,10 @@
#include <net/sock.h>
#include <uapi/linux/batman_adv.h>
-#include "originator.h"
#include "bridge_loop_avoidance.h"
#include "gateway_client.h"
#include "hard-interface.h"
+#include "originator.h"
#include "soft-interface.h"
#include "translation-table.h"
diff --git a/net/batman-adv/netlink.h b/net/batman-adv/netlink.h
index ef861db..fac7d91 100644
--- a/net/batman-adv/netlink.h
+++ b/net/batman-adv/netlink.h
@@ -18,12 +18,9 @@
#ifndef _NET_BATMAN_ADV_NETLINK_H_
#define _NET_BATMAN_ADV_NETLINK_H_
#include "main.h"
-#include <linux/compiler.h>
-#include <linux/genetlink.h>
#include <net/genetlink.h>
-#include <net/netlink.h>
struct nlmsghdr;
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-16 17:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 16:08 [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 01/11] batman-adv: Handle parent interfaces in a different netns Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 02/11] batman-adv: Suppress debugfs entries for netns's Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 03/11] batman-adv: netlink: add routing_algo query Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 04/11] batman-adv: netlink: hardif query Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 05/11] batman-adv: netlink: add translation table query Andrew Lunn
2016-05-16 16:41 ` Sven Eckelmann
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 06/11] batman-adv: netlink: add originator and neighbor table queries Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 07/11] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations Andrew Lunn
2016-05-16 16:44 ` Sven Eckelmann
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 08/11] batman-adv: add B.A.T.M.A.N. V " Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 09/11] batman-adv: add B.A.T.M.A.N. Dump gateways via netlink Andrew Lunn
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 10/11] batman-adv: add B.A.T.M.A.N. Dump BLA claims " Andrew Lunn
2016-05-16 16:41 ` Sven Eckelmann
2016-05-16 16:08 ` [B.A.T.M.A.N.] [PATCH v5 11/11] batman-adv: Indicate netlink socket can be used with netns Andrew Lunn
2016-05-16 17:42 ` Sven Eckelmann [this message]
2016-05-17 13:58 ` [B.A.T.M.A.N.] [PATCH v5 00/11] netns and netlink support Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646180.Hz16yHrbtt@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox