From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <a@unstable.cc>
Cc: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files
Date: Sat, 21 May 2016 14:32:38 +0200 [thread overview]
Message-ID: <1658184.bVJx44a0QY@sven-edge> (raw)
In-Reply-To: <20160521121756.27450-2-a@unstable.cc>
[-- Attachment #1: Type: text/plain, Size: 899 bytes --]
On Saturday 21 May 2016 20:17:56 Antonio Quartulli wrote:
> main.h is always included after the #ifdef guard except for
> bat_v_elp.h. Move it at the right place.
>
> Cc: Sven Eckelmann <sven@narfation.org>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
> ---
Good find :)
Reviewed-by: Sven Eckelmann <sven@narfation.org>
Kind regards,
Sven
> net/batman-adv/bat_v_elp.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/batman-adv/bat_v_elp.h b/net/batman-adv/bat_v_elp.h
> index cc130b2..be17c0b 100644
> --- a/net/batman-adv/bat_v_elp.h
> +++ b/net/batman-adv/bat_v_elp.h
> @@ -15,11 +15,11 @@
> * along with this program; if not, see <http://www.gnu.org/licenses/>.
> */
>
> -#include "main.h"
> -
> #ifndef _NET_BATMAN_ADV_BAT_V_ELP_H_
> #define _NET_BATMAN_ADV_BAT_V_ELP_H_
>
> +#include "main.h"
> +
> struct sk_buff;
> struct work_struct;
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-21 12:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 12:17 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Antonio Quartulli
2016-05-21 12:17 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: move include line at the same place as other files Antonio Quartulli
2016-05-21 12:32 ` Sven Eckelmann [this message]
2016-06-06 16:12 ` Marek Lindner
2016-05-21 12:30 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: remove useless forward declarations Sven Eckelmann
2016-05-21 12:32 ` Antonio Quartulli
2016-06-06 16:10 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1658184.bVJx44a0QY@sven-edge \
--to=sven@narfation.org \
--cc=a@unstable.cc \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox