Re: [B.A.T.M.A.N.] Memory leakage

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]

On Freitag, 19. Mai 2017 08:29:29 CEST Andreas Pape wrote:
[...]
> I think the line with the "return NET_RX_DROP;" needs to be replaced by
> "goto skb_free;".

Yes

> How is the correct procedure to change this? As this patch has already
> been committed to
> the git repo I guess I should send a new patch or is a new version of the
> old patch necessary?

Thanks for debugging this. Please sent a new patch based on master [1] and add 
following line above your Signed-off-by

    Fixes: bfe2a1971f43 ("batman-adv: drop unicast packets from other backbone gw")

We will take care of submitting it to Linux net for Linux 4.12. If you still
have problems with your IT department then you can either send the patch from 
a private mail account (git-send-email will then add an extra "From:" line to 
keep your phoenixcontact.com mail address as author mail address) or (if not
otherwise possible) sent it again as attachment to me or Simon. We can then
forward it to the mailing list.

Kind regards,
	Sven

[1] Your patch is currently only in master. It should actually be in maint but
    Simon hadn't found the time to release master as 2017.1. Which is not to
    bad because now we can still incorporate your fix.
    It would be different when the patch would already be part of maint. Then
    it would be better when you should create your patch on top of maint

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]