Re: [B.A.T.M.A.N.] [PATCH] fixes a uint32 overflow

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]

On Sunday 17 May 2015 11:27:32 Ruben Wisniewski wrote:
> Signed-off-by: Ruben Wisniewsi <ruben@vfn-nrw.de>
> ---
>  net/batman-adv/gateway_client.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/batman-adv/gateway_client.c
> b/net/batman-adv/gateway_client.c index bb01586..1f50661 100644
> --- a/net/batman-adv/gateway_client.c
> +++ b/net/batman-adv/gateway_client.c
> @@ -153,7 +153,7 @@ batadv_gw_get_best_gw_node(struct batadv_priv *bat_priv)
> struct batadv_neigh_node *router;
>  	struct batadv_neigh_ifinfo *router_ifinfo;
>  	struct batadv_gw_node *gw_node, *curr_gw = NULL;
> -	uint32_t max_gw_factor = 0, tmp_gw_factor = 0;
> +	uint64_t max_gw_factor = 0, tmp_gw_factor = 0;
>  	uint32_t gw_divisor;
>  	uint8_t max_tq = 0;
>  	uint8_t tq_avg;

This patch is not following

 * https://www.open-mesh.org/projects/open-mesh/wiki/Contribute
 * https://www.kernel.org/doc/Documentation/SubmittingPatches
 * https://www.kernel.org/doc/Documentation/CodingStyle

Please add the "batman-adv: " prefix for the Subject.

The summary in the subject itself also needs to be refined. The relevant part 
in SubmittingPatches for the subject can be found under "14) The canonical 
patch format".

An explanation in the commit message why there is an overflow would be nice.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 819 bytes --]