Re: [B.A.T.M.A.N.] [PATCH] batman-adv: don't free resources when DAT is disabled

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On Monday 29 October 2012 16:10:01 Antonio Quartulli wrote:
> Freeing all the resources when DAT is disabled need a much more complicated
> locking system to prevent concurrent enable/disable operations to destroy
> the internal state of the component. For now it is safe to avoid such
> freeing operation at all when DAT gets disabled.
> 
> Signed-off-by: Antonio Quartulli <ordex@autistici.org>
> ---
>  distributed-arp-table.c | 10 ----------
>  sysfs.c                 |  3 +--
>  2 files changed, 1 insertion(+), 12 deletions(-)
> 
> diff --git a/distributed-arp-table.c b/distributed-arp-table.c
> index c933615..7921030 100644
> --- a/distributed-arp-table.c
> +++ b/distributed-arp-table.c
> @@ -1061,13 +1061,3 @@ out:
>  		batadv_dat_entry_free_ref(dat_entry);
>  	return ret;
>  }
> -
> -void batadv_dat_switch(struct net_device *net_dev)
> -{
> -	struct batadv_priv *bat_priv = netdev_priv(net_dev);
> -
> -	if (atomic_read(&bat_priv->distributed_arp_table))
> -		batadv_dat_init(bat_priv);
> -	else
> -		batadv_dat_free(bat_priv);
> -}

Also remove it from distributed-arp-table.h

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]